From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: Format change for btrfs fi df
Date: Wed, 13 Jan 2016 08:35:19 +0800 [thread overview]
Message-ID: <56959BC7.7060201@cn.fujitsu.com> (raw)
In-Reply-To: <20160112142806.GL4227@twin.jikos.cz>
David Sterba wrote on 2016/01/12 15:28 +0100:
> On Mon, Dec 14, 2015 at 01:19:56PM +0800, Qu Wenruo wrote:
>> The GlobalReserve space in 'btrfs fi df' is always confusing for a lot
>> of users.
>> As it is not a special chunk type like DATA or METADATA, it's in fact a
>> sub-type of METADATA.
>>
>> So change the output to skip GlobalReserve by default, and adding its
>> total to metadata used.
>> And add a new option '-r|--reserve' to show the GlobalReserve, but skip
>> the profile of GlobalReserve.
>
> How about this:
>
> - keep the global reserve in the output, separate from metadata and not
> accounted
> - add new option to account the global reserve into metadata and then
> drop it from the output
I'm OK about it, although that would just make '-r' option default.
But anyway, the profile of GlobalReserve should not be output.
Thanks,
Qu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2016-01-13 0:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 5:19 [PATCH] btrfs-progs: Format change for btrfs fi df Qu Wenruo
2016-01-05 2:01 ` Qu Wenruo
2016-01-11 15:51 ` David Sterba
2016-01-12 0:20 ` Duncan
2016-01-12 14:28 ` David Sterba
2016-01-12 19:55 ` Goffredo Baroncelli
2016-01-13 0:37 ` Qu Wenruo
2016-01-12 20:46 ` Henk Slager
2016-01-13 0:35 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56959BC7.7060201@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.