Re: [PATCH] btrfs-progs: Format change for btrfs fi df

[Qu Wenruo <quwenruo@cn.fujitsu.com>]

Goffredo Baroncelli wrote on 2016/01/12 20:55 +0100:
> On 2016-01-12 15:28, David Sterba wrote:
> [...]
>> How about this:
>>
>> - keep the global reserve in the output, separate from metadata and not
>>     accounted
>> - add new option to account the global reserve into metadata and then
>>     drop it from the output
>
>
> Instead of dropping it, what about prefixing it with '\_' in order to show that
> it is a subtype of metadata (it is not a my idea, I read this sometime ago in
> this mailing list) ?
>
> $ btrfs fi df /
> Data, single: total=29.00GiB, used=21.01GiB
> System, single: total=32.00MiB, used=16.00KiB
> Metadata, single: total=2.00GiB, used=716.59MiB
> \_GlobalReserve, single: total=240.00MiB, used=0.00B

Yes, that's what my new patch does:

See the code:
+			printf(" \\- %s: reserved=%s, used=%s\n",
+				btrfs_group_type_str(sp->flags),
+				pretty_size_mode(sp->total_bytes, unit_mode),
+				pretty_size_mode(sp->used_bytes, unit_mode));

Although I'm using "\-" other than "\_".

Thanks,
Qu

>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
>