From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>,
Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v4 0/4] Ensure that we can build without libgen.h
Date: Wed, 13 Jan 2016 07:15:06 +0100 [thread overview]
Message-ID: <5695EB6A.1030402@web.de> (raw)
In-Reply-To: <xmqq7fjeqjae.fsf@gitster.mtv.corp.google.com>
On 01/13/2016 03:56 AM, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> Hi Johannes,
>> ...
>> I was somewhat disappointed that you ignored the implementation of
>> gitbasename() and gitdirname() that was included in the test-libgen.c
>> file that I sent you. I had hoped they would be (at worst) a good starting
>> point if you found them to be lacking for your use case (ie. for the
>> 64-bit versions of MSVC/MinGW).
> Sorry to hear that, but the 'next' branch has just been rewound and
> rebuilt with this series, so it is too late to replace them with
> another round of reroll. It however is never too late to improve
> with incremental updates, though, so please work together and send
> in a follow-up patch series as/if needed.
>
Is there a chance to keep it in next (and not merge to master) until
we have found a solution for the broken t0060 test under Mac OS X ?
next prev parent reply other threads:[~2016-01-13 6:15 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 14:50 [PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2015-09-30 18:24 ` Junio C Hamano
2016-01-08 16:17 ` Johannes Schindelin
2015-09-30 18:57 ` Ramsay Jones
2016-01-08 16:18 ` Johannes Schindelin
2016-01-08 16:21 ` [PATCH v2 0/4] Ensure that we can build without libgen.h Johannes Schindelin
2016-01-08 16:21 ` [PATCH v2 1/4] Refactor skipping DOS drive prefixes Johannes Schindelin
2016-01-08 21:51 ` Eric Sunshine
2016-01-08 22:07 ` Junio C Hamano
2016-01-11 9:32 ` Johannes Schindelin
2016-01-11 15:58 ` Junio C Hamano
2016-01-08 16:21 ` [PATCH v2 2/4] compat/basename: make basename() conform to POSIX Johannes Schindelin
2016-01-08 18:45 ` Junio C Hamano
2016-01-09 14:53 ` Johannes Schindelin
2016-01-11 16:01 ` Junio C Hamano
2016-01-08 16:21 ` [PATCH v2 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2016-01-08 18:53 ` Junio C Hamano
2016-01-08 16:21 ` [PATCH v2 4/4] t0060: verify that basename() and dirname() work as expected Johannes Schindelin
2016-01-10 4:17 ` Eric Sunshine
2016-01-11 10:50 ` Johannes Schindelin
2016-01-13 18:52 ` Michael Blume
2016-01-13 19:43 ` Junio C Hamano
2016-01-14 6:09 ` Johannes Schindelin
2016-01-11 18:29 ` [PATCH v3 0/4] Ensure that we can build without libgen.h Johannes Schindelin
2016-01-11 18:29 ` [PATCH v3 1/4] Refactor skipping DOS drive prefixes Johannes Schindelin
2016-01-11 18:29 ` [PATCH v3 2/4] compat/basename: make basename() conform to POSIX Johannes Schindelin
2016-01-11 18:30 ` [PATCH v3 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2016-01-11 20:33 ` Eric Sunshine
2016-01-11 22:56 ` Junio C Hamano
2016-01-12 7:57 ` Johannes Schindelin
2016-01-11 18:30 ` [PATCH v3 4/4] t0060: verify that basename() and dirname() work as expected Johannes Schindelin
2016-01-11 22:59 ` [PATCH v3 0/4] Ensure that we can build without libgen.h Junio C Hamano
2016-01-12 7:57 ` [PATCH v4 " Johannes Schindelin
2016-01-12 7:57 ` [PATCH v4 1/4] Refactor skipping DOS drive prefixes Johannes Schindelin
2016-01-22 18:50 ` Johannes Sixt
2016-01-22 19:09 ` Junio C Hamano
2016-01-23 8:25 ` Johannes Schindelin
2016-01-23 19:02 ` Johannes Sixt
2016-01-24 10:56 ` Johannes Schindelin
2016-01-24 12:36 ` Johannes Sixt
2016-01-24 22:12 ` Junio C Hamano
2016-01-25 21:47 ` [PATCH] mingw: avoid linking to the C library's isalpha() Johannes Sixt
2016-01-25 22:04 ` Junio C Hamano
2016-01-12 7:57 ` [PATCH v4 2/4] compat/basename: make basename() conform to POSIX Johannes Schindelin
2016-01-13 0:49 ` Ramsay Jones
2016-01-13 7:14 ` Johannes Schindelin
2016-01-12 7:57 ` [PATCH v4 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2016-01-13 0:55 ` Ramsay Jones
2016-01-13 7:40 ` Johannes Schindelin
2016-01-13 16:44 ` Ramsay Jones
2016-01-12 7:57 ` [PATCH v4 4/4] t0060: verify that basename() and dirname() work as expected Johannes Schindelin
2016-01-13 0:58 ` Ramsay Jones
2016-01-13 7:17 ` Johannes Schindelin
[not found] ` <5695E4FB.2060705@web.de>
2016-01-13 9:27 ` Johannes Schindelin
2016-01-13 16:46 ` Ramsay Jones
2016-01-13 16:34 ` Ramsay Jones
2016-01-13 17:20 ` Junio C Hamano
2016-01-13 18:53 ` Johannes Schindelin
2016-01-13 0:44 ` [PATCH v4 0/4] Ensure that we can build without libgen.h Ramsay Jones
2016-01-13 2:56 ` Junio C Hamano
2016-01-13 6:15 ` Torsten Bögershausen [this message]
2016-01-13 7:38 ` Johannes Schindelin
2016-01-13 7:02 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5695EB6A.1030402@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=ramsay@ramsayjones.plus.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.