From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v4 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease
Date: Wed, 13 Jan 2016 16:44:37 +0000 [thread overview]
Message-ID: <56967EF5.60202@ramsayjones.plus.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1601130838430.2964@virtualbox>
On 13/01/16 07:40, Johannes Schindelin wrote:
> Hi Ramsay,
>
> On Wed, 13 Jan 2016, Ramsay Jones wrote:
>
>> Also, when compiling on Cygwin with NO_LIBGEN_H, I need to
>> include the following here:
>>
>> #undef basename
>>
>> in order to suppress approx 230 warnings about the redefinition
>> of the basename macro.
>>
>> (I suppose that should go in the previous commit. dunno)
>
> I think this is an incorrect use of NO_LIBGEN_H (because Cygwin obviously
> has it), but in any case, it is a completely independent issue from
> fixing/testing basename()/dirname(), so your #undef basename should be in
> a completely separate commit, methinks.
OK. I think this worked fine on 32-bit cygwin, but the system headers
have changed quite a bit on 64-bit cygwin and I only tried it for the
first time yesterday. (It was helpful in the debugging process at one
point to be able to build with NO_LIBGEN_H on all platforms ...)
ATB,
Ramsay Jones
next prev parent reply other threads:[~2016-01-13 16:45 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 14:50 [PATCH] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2015-09-30 18:24 ` Junio C Hamano
2016-01-08 16:17 ` Johannes Schindelin
2015-09-30 18:57 ` Ramsay Jones
2016-01-08 16:18 ` Johannes Schindelin
2016-01-08 16:21 ` [PATCH v2 0/4] Ensure that we can build without libgen.h Johannes Schindelin
2016-01-08 16:21 ` [PATCH v2 1/4] Refactor skipping DOS drive prefixes Johannes Schindelin
2016-01-08 21:51 ` Eric Sunshine
2016-01-08 22:07 ` Junio C Hamano
2016-01-11 9:32 ` Johannes Schindelin
2016-01-11 15:58 ` Junio C Hamano
2016-01-08 16:21 ` [PATCH v2 2/4] compat/basename: make basename() conform to POSIX Johannes Schindelin
2016-01-08 18:45 ` Junio C Hamano
2016-01-09 14:53 ` Johannes Schindelin
2016-01-11 16:01 ` Junio C Hamano
2016-01-08 16:21 ` [PATCH v2 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2016-01-08 18:53 ` Junio C Hamano
2016-01-08 16:21 ` [PATCH v2 4/4] t0060: verify that basename() and dirname() work as expected Johannes Schindelin
2016-01-10 4:17 ` Eric Sunshine
2016-01-11 10:50 ` Johannes Schindelin
2016-01-13 18:52 ` Michael Blume
2016-01-13 19:43 ` Junio C Hamano
2016-01-14 6:09 ` Johannes Schindelin
2016-01-11 18:29 ` [PATCH v3 0/4] Ensure that we can build without libgen.h Johannes Schindelin
2016-01-11 18:29 ` [PATCH v3 1/4] Refactor skipping DOS drive prefixes Johannes Schindelin
2016-01-11 18:29 ` [PATCH v3 2/4] compat/basename: make basename() conform to POSIX Johannes Schindelin
2016-01-11 18:30 ` [PATCH v3 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2016-01-11 20:33 ` Eric Sunshine
2016-01-11 22:56 ` Junio C Hamano
2016-01-12 7:57 ` Johannes Schindelin
2016-01-11 18:30 ` [PATCH v3 4/4] t0060: verify that basename() and dirname() work as expected Johannes Schindelin
2016-01-11 22:59 ` [PATCH v3 0/4] Ensure that we can build without libgen.h Junio C Hamano
2016-01-12 7:57 ` [PATCH v4 " Johannes Schindelin
2016-01-12 7:57 ` [PATCH v4 1/4] Refactor skipping DOS drive prefixes Johannes Schindelin
2016-01-22 18:50 ` Johannes Sixt
2016-01-22 19:09 ` Junio C Hamano
2016-01-23 8:25 ` Johannes Schindelin
2016-01-23 19:02 ` Johannes Sixt
2016-01-24 10:56 ` Johannes Schindelin
2016-01-24 12:36 ` Johannes Sixt
2016-01-24 22:12 ` Junio C Hamano
2016-01-25 21:47 ` [PATCH] mingw: avoid linking to the C library's isalpha() Johannes Sixt
2016-01-25 22:04 ` Junio C Hamano
2016-01-12 7:57 ` [PATCH v4 2/4] compat/basename: make basename() conform to POSIX Johannes Schindelin
2016-01-13 0:49 ` Ramsay Jones
2016-01-13 7:14 ` Johannes Schindelin
2016-01-12 7:57 ` [PATCH v4 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Johannes Schindelin
2016-01-13 0:55 ` Ramsay Jones
2016-01-13 7:40 ` Johannes Schindelin
2016-01-13 16:44 ` Ramsay Jones [this message]
2016-01-12 7:57 ` [PATCH v4 4/4] t0060: verify that basename() and dirname() work as expected Johannes Schindelin
2016-01-13 0:58 ` Ramsay Jones
2016-01-13 7:17 ` Johannes Schindelin
[not found] ` <5695E4FB.2060705@web.de>
2016-01-13 9:27 ` Johannes Schindelin
2016-01-13 16:46 ` Ramsay Jones
2016-01-13 16:34 ` Ramsay Jones
2016-01-13 17:20 ` Junio C Hamano
2016-01-13 18:53 ` Johannes Schindelin
2016-01-13 0:44 ` [PATCH v4 0/4] Ensure that we can build without libgen.h Ramsay Jones
2016-01-13 2:56 ` Junio C Hamano
2016-01-13 6:15 ` Torsten Bögershausen
2016-01-13 7:38 ` Johannes Schindelin
2016-01-13 7:02 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56967EF5.60202@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.