From: Ian Abbott <abbotti@mev.co.uk>
To: "Spencer E. Olson" <olsonse@umich.edu>, devel@driverdev.osuosl.org
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg
Date: Wed, 13 Jan 2016 10:37:15 +0000 [thread overview]
Message-ID: <569628DB.8070105@mev.co.uk> (raw)
In-Reply-To: <1452619998-14586-1-git-send-email-olsonse@umich.edu>
On 12/01/16 17:33, Spencer E. Olson wrote:
> This fixes a bug in function ni_tio_input_inttrig(). The trigger number
> should be compared to cmd->start_arg, not cmd->start_src.
>
> Fixes: 6a760394d7eb ("staging: comedi: ni_tiocmd: clarify the
> cmd->start_arg validation and use")
> Cc: <stable@vger.kernel.org> # 3.17+
> Signed-off-by: Spencer E. Olson <olsonse@umich.edu>
> ---
> Added description suggested by Ian and Dan. Added Fixes:, CC: tags as
> suggested by Ian.
>
> drivers/staging/comedi/drivers/ni_tiocmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
> index 437f723..823e479 100644
> --- a/drivers/staging/comedi/drivers/ni_tiocmd.c
> +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
> @@ -92,7 +92,7 @@ static int ni_tio_input_inttrig(struct comedi_device *dev,
> unsigned long flags;
> int ret = 0;
>
> - if (trig_num != cmd->start_src)
> + if (trig_num != cmd->start_arg)
> return -EINVAL;
>
> spin_lock_irqsave(&counter->lock, flags);
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2016-01-13 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56951A9A.8060409@mev.co.uk>
2016-01-12 17:33 ` [PATCH v2] staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg Spencer E. Olson
2016-01-12 17:56 ` Ian Abbott
[not found] ` <CAOx9PeiUWp6DPw+PFKDyZXc1s3kF9pGfhW1oc+JSZ3nGf-5_Mw@mail.gmail.com>
2016-01-13 10:36 ` Ian Abbott
2016-01-13 10:56 ` Dan Carpenter
2016-01-12 22:12 ` Dan Carpenter
2016-01-13 10:37 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569628DB.8070105@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=olsonse@umich.edu \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.