[PATCH] debugfs: don't emit parameter names

[PATCH] debugfs: don't emit parameter names

[Karol Herbst]

fixes a compile error

Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
---
 drm/nouveau/nouveau_debugfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drm/nouveau/nouveau_debugfs.h b/drm/nouveau/nouveau_debugfs.h
index 52c7161..b8c03ff 100644
--- a/drm/nouveau/nouveau_debugfs.h
+++ b/drm/nouveau/nouveau_debugfs.h
@@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
 }
 
 static inline int
-nouveau_debugfs_init(struct nouveau_drm *)
+nouveau_debugfs_init(struct nouveau_drm *drm)
 {
 	return 0;
 }
 
 static inline void
-nouveau_debugfs_fini(struct nouveau_drm *)
+nouveau_debugfs_fini(struct nouveau_drm *drm)
 {
 }
 
-- 
2.7.0

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH] debugfs: don't emit parameter names

[Samuel Pitoiset]

On 01/13/2016 02:12 PM, Karol Herbst wrote:
> fixes a compile error

Yeah, and this is probably not the only error you will hit...
This is happens when CONFIG_DEBUG_FS is set.

You need to include "nouveau_drm.h" and to fix nouveau_debugfs.c too.

>
> Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
> ---
>   drm/nouveau/nouveau_debugfs.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drm/nouveau/nouveau_debugfs.h b/drm/nouveau/nouveau_debugfs.h
> index 52c7161..b8c03ff 100644
> --- a/drm/nouveau/nouveau_debugfs.h
> +++ b/drm/nouveau/nouveau_debugfs.h
> @@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
>   }
>
>   static inline int
> -nouveau_debugfs_init(struct nouveau_drm *)
> +nouveau_debugfs_init(struct nouveau_drm *drm)
>   {
>   	return 0;
>   }
>
>   static inline void
> -nouveau_debugfs_fini(struct nouveau_drm *)
> +nouveau_debugfs_fini(struct nouveau_drm *drm)
>   {
>   }
>
>

-- 
-Samuel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [PATCH] debugfs: don't emit parameter names

[Samuel Pitoiset]

On 01/13/2016 02:33 PM, Samuel Pitoiset wrote:
>
>
> On 01/13/2016 02:12 PM, Karol Herbst wrote:
>> fixes a compile error
>
> Yeah, and this is probably not the only error you will hit...
> This is happens when CONFIG_DEBUG_FS is set.
>
> You need to include "nouveau_drm.h" and to fix nouveau_debugfs.c too.

Okay I read the patch too quickly. nouveau-debugfs.c is not compiled 
when CONFIG_DEBUG_FS is disabled, so this is enough to fix the 
compilation error.

However, I think your commit message needs to be updated.
What about s/emit/omit/? :-)

With that commit message fixed, this patch is:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

>
>>
>> Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
>> ---
>>   drm/nouveau/nouveau_debugfs.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drm/nouveau/nouveau_debugfs.h
>> b/drm/nouveau/nouveau_debugfs.h
>> index 52c7161..b8c03ff 100644
>> --- a/drm/nouveau/nouveau_debugfs.h
>> +++ b/drm/nouveau/nouveau_debugfs.h
>> @@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
>>   }
>>
>>   static inline int
>> -nouveau_debugfs_init(struct nouveau_drm *)
>> +nouveau_debugfs_init(struct nouveau_drm *drm)
>>   {
>>       return 0;
>>   }
>>
>>   static inline void
>> -nouveau_debugfs_fini(struct nouveau_drm *)
>> +nouveau_debugfs_fini(struct nouveau_drm *drm)
>>   {
>>   }
>>
>>
>

-- 
-Samuel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau