From: Laszlo Ersek <lersek@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
Shannon Zhao <shannon.zhao@linaro.org>
Cc: peter.maydell@linaro.org, ard.biesheuvel@linaro.org,
edk2-devel@ml01.01.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, zhaoshenglong@huawei.com
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2] ARM: Virt: Don't generate RTC ACPI device when using UEFI
Date: Wed, 13 Jan 2016 17:26:12 +0100 [thread overview]
Message-ID: <56967AA4.40300@redhat.com> (raw)
In-Reply-To: <20160113161641.GC10709@hawk.localdomain>
On 01/13/16 17:16, Andrew Jones wrote:
> On Wed, Jan 13, 2016 at 10:54:17PM +0800, Shannon Zhao wrote:
>> When booting the VM with UEFI, UEFI takes ownership of the RTC hardware.
>> While UEFI can use libfdt to disable the RTC device node in the DTB that
>> it passes to the OS, it cannot modify AML. Therefore, we won't generate
>> the RTC ACPI device at all when using UEFI.
>
> I think a condensed comment similar to this commit message would be nice
> in build_dsdt, or somewhere. We have a policy for mach-virt of generating
> ACPI for everything we generate DT. It'd be good if we documented all the
> divergences in order to avoid confusion. [...]
Good idea!
Thanks
Laszlo
WARNING: multiple messages have this Message-ID (diff)
From: Laszlo Ersek <lersek@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
Shannon Zhao <shannon.zhao@linaro.org>
Cc: peter.maydell@linaro.org, ard.biesheuvel@linaro.org,
edk2-devel@ml01.01.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, zhaoshenglong@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2] ARM: Virt: Don't generate RTC ACPI device when using UEFI
Date: Wed, 13 Jan 2016 17:26:12 +0100 [thread overview]
Message-ID: <56967AA4.40300@redhat.com> (raw)
In-Reply-To: <20160113161641.GC10709@hawk.localdomain>
On 01/13/16 17:16, Andrew Jones wrote:
> On Wed, Jan 13, 2016 at 10:54:17PM +0800, Shannon Zhao wrote:
>> When booting the VM with UEFI, UEFI takes ownership of the RTC hardware.
>> While UEFI can use libfdt to disable the RTC device node in the DTB that
>> it passes to the OS, it cannot modify AML. Therefore, we won't generate
>> the RTC ACPI device at all when using UEFI.
>
> I think a condensed comment similar to this commit message would be nice
> in build_dsdt, or somewhere. We have a policy for mach-virt of generating
> ACPI for everything we generate DT. It'd be good if we documented all the
> divergences in order to avoid confusion. [...]
Good idea!
Thanks
Laszlo
next prev parent reply other threads:[~2016-01-13 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 14:54 [Qemu-arm] [PATCH v2] ARM: Virt: Don't generate RTC ACPI device when using UEFI Shannon Zhao
2016-01-13 14:54 ` [Qemu-devel] " Shannon Zhao
2016-01-13 15:04 ` Ard Biesheuvel
2016-01-13 15:06 ` Laszlo Ersek
2016-01-13 16:16 ` [Qemu-arm] " Andrew Jones
2016-01-13 16:16 ` Andrew Jones
2016-01-13 16:26 ` Laszlo Ersek [this message]
2016-01-13 16:26 ` Laszlo Ersek
2016-01-15 14:34 ` [Qemu-arm] " Peter Maydell
2016-01-15 14:34 ` Peter Maydell
2016-01-15 14:37 ` [Qemu-arm] " Shannon Zhao
2016-01-15 14:37 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56967AA4.40300@redhat.com \
--to=lersek@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=drjones@redhat.com \
--cc=edk2-devel@ml01.01.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.