From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Jussi Kukkonen <jussi.kukkonen@intel.com>,
Anibal Limon <anibal.limon@intel.com>
Cc: Yocto Project <yocto@yoctoproject.org>
Subject: Re: [AUH] gpgme: upgrading to 1.6.0 SUCCEEDED
Date: Wed, 13 Jan 2016 11:08:40 -0600 [thread overview]
Message-ID: <56968498.5070207@linux.intel.com> (raw)
In-Reply-To: <CAHiDW_GGH6X3vyFXe5+JCZz3pn8L0HPDfxN3BsjT3nbYC_oj_w@mail.gmail.com>
Hi Jussi,
Thanks for the feedback, comments below...
Cheers,
alimon
On 01/13/2016 07:42 AM, Jussi Kukkonen wrote:
> Hi,
>
> On 11 January 2016 at 06:21, <auh@auh.yoctoproject.org> wrote:
>
>> Hello,
>>
>> You are receiving this email because you are the maintainer
>> of *gpgme* recipe and this is to let you know that the automatic attempt
>> to upgrade the recipe to *1.6.0* has Succeeded.
>>
>
>
> First, thanks for the effort Anibal, the upgrade helper is looking very
> useful: I'm certainly going to use it.
>
> Couple of small issues:
> * The license diffs do not seem correct: they look like like diffs between
> an empty file and the new license file version (see the parent gpgme post
> for example)
Yes i see, i'll review/fix the problem.
> * Is the decision to use "buildhistory-diff -a" intentional? I'm not 100%
> sure what exactly "-a" option brings with it but I've usually avoided it on
> upgrades because the path changes in -dbg package are so verbose as to
> hide everything else...
It was mine decision for provide more output for the maintainers but if
you think that's enough without -a that's ok.
May be a good idea will be to sent two files one,
- buildhistory-diff.txt: Without -a.
- buildhistory-diff-all.txt: With -a/
Comments?
>
> Thanks,
> Jussi
>
>
>> *LICENSE CHANGED* please review the gpgme.h.in.diff file and update the
>> LICENSE
>> variable in the recipe if is needed.
>>
>> The recipe has been successfully compiled for machines qemux86,
>> qemux86-64, qemuarm, qemumips, qemuppc.
>>
>> Next steps:
>> - apply the patch: git am 0001-gpgme-upgrade-to-1.6.0.patch
>> - check that required upstream patches have not been commented from
>> the recipe,
>> if upstream patches were commented the reason is specified in the
>> commit message.
>> - compile an image that contains the package
>> - perform some basic sanity tests
>> - amend the patch and sign it off: git commit -s --reset-author --amend
>> - send it to the list
>>
>> Attached are the patch, license diff (if change) and bitbake log.
>> Any problem please contact Anibal Limon <anibal.limon@intel.com>.
>>
>> Regards,
>> The Upgrade Helper
>
>
>
next prev parent reply other threads:[~2016-01-13 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <37b747fd-ad90-45e9-b3cc-4595c4d83661@fmsmsx108.amr.corp.intel.com>
2016-01-13 13:42 ` [AUH] gpgme: upgrading to 1.6.0 SUCCEEDED Jussi Kukkonen
2016-01-13 17:08 ` Aníbal Limón [this message]
2016-01-13 20:03 ` Paul Eggleton
2016-01-13 20:19 ` Burton, Ross
2016-01-13 20:27 ` Anibal Limon
2016-01-13 20:28 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56968498.5070207@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=anibal.limon@intel.com \
--cc=jussi.kukkonen@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.