From: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Tom Rini <trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
Cc: u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Max Krummenacher
<max.krummenacher-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>,
Joe Hershberger <joe.hershberger-acOepvfBmUk@public.gmane.org>
Subject: Re: [U-Boot] [PATCH v4 1/6] common/image-fdt.c: Make boot_get_fdt() perform a check for Android images
Date: Thu, 14 Jan 2016 09:47:12 +0800 [thread overview]
Message-ID: <5696FE20.6080003@rock-chips.com> (raw)
In-Reply-To: <20160113152157.GY3359@bill-the-cat>
Hi Tom,
On 2016-1-13 23:21, Tom Rini wrote:
> On Wed, Jan 13, 2016 at 04:53:15PM +0800, Jeffy Chen wrote:
>
>> Android images don't have a fdt.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>> Acked-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>> common/image-fdt.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/common/image-fdt.c b/common/image-fdt.c
>> index 5e4e5bd..41aaa0d 100644
>> --- a/common/image-fdt.c
>> +++ b/common/image-fdt.c
>> @@ -379,6 +379,10 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch,
>> (long)fdt_addr);
>> }
>> break;
>> +#ifdef CONFIG_ANDROID_BOOT_IMAGE
>> + case IMAGE_FORMAT_ANDROID:
>> + goto no_fdt;
>> +#endif
>> default:
>> puts("ERROR: Did not find a cmdline Flattened Device Tree\n");
>> goto no_fdt;
> Hang on, this doesn't seem right. Rob or Paul can you comment more
> here? I know we've gone through some issues in the past with respect to
> booting Android and FDT. Thanks!
Oh! How careless i was...Seems we don't need this patch, the default
case is enough :)
WARNING: multiple messages have this Message-ID (diff)
From: Jeffy Chen <jeffy.chen@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/6] common/image-fdt.c: Make boot_get_fdt() perform a check for Android images
Date: Thu, 14 Jan 2016 09:47:12 +0800 [thread overview]
Message-ID: <5696FE20.6080003@rock-chips.com> (raw)
In-Reply-To: <20160113152157.GY3359@bill-the-cat>
Hi Tom,
On 2016-1-13 23:21, Tom Rini wrote:
> On Wed, Jan 13, 2016 at 04:53:15PM +0800, Jeffy Chen wrote:
>
>> Android images don't have a fdt.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> Acked-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>> common/image-fdt.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/common/image-fdt.c b/common/image-fdt.c
>> index 5e4e5bd..41aaa0d 100644
>> --- a/common/image-fdt.c
>> +++ b/common/image-fdt.c
>> @@ -379,6 +379,10 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch,
>> (long)fdt_addr);
>> }
>> break;
>> +#ifdef CONFIG_ANDROID_BOOT_IMAGE
>> + case IMAGE_FORMAT_ANDROID:
>> + goto no_fdt;
>> +#endif
>> default:
>> puts("ERROR: Did not find a cmdline Flattened Device Tree\n");
>> goto no_fdt;
> Hang on, this doesn't seem right. Rob or Paul can you comment more
> here? I know we've gone through some issues in the past with respect to
> booting Android and FDT. Thanks!
Oh! How careless i was...Seems we don't need this patch, the default
case is enough :)
next prev parent reply other threads:[~2016-01-14 1:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 8:53 [PATCH v4 0/6] rockchip: kylin: Boot with android boot image Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
[not found] ` <1452675200-15941-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-13 8:53 ` [PATCH v4 1/6] common/image-fdt.c: Make boot_get_fdt() perform a check for Android images Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
2016-01-13 15:21 ` Tom Rini
2016-01-13 15:21 ` [U-Boot] " Tom Rini
2016-01-14 1:47 ` Jeffy Chen [this message]
2016-01-14 1:47 ` Jeffy Chen
2016-01-13 8:53 ` [PATCH v4 2/6] ARM: bootm: Try to use relocated ramdisk Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
2016-01-13 15:27 ` Tom Rini
2016-01-13 15:27 ` [U-Boot] " Tom Rini
2016-01-13 8:53 ` [PATCH v4 3/6] rockchip: rk3036: Bind GPIO banks Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
2016-01-13 15:28 ` Tom Rini
2016-01-13 15:28 ` [U-Boot] " Tom Rini
2016-01-13 8:53 ` [PATCH v4 4/6] rockchip: kylin: Add default gpt partition table Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
2016-01-13 15:28 ` Tom Rini
2016-01-13 15:28 ` [U-Boot] " Tom Rini
2016-01-13 8:53 ` [PATCH v4 5/6] rockchip: kylin: Enable boot with android boot image Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
2016-01-13 15:28 ` Tom Rini
2016-01-13 15:28 ` [U-Boot] " Tom Rini
2016-01-14 2:31 ` Jeffy Chen
2016-01-14 2:31 ` Jeffy Chen
2016-01-14 16:22 ` Tom Rini
2016-01-14 16:22 ` [U-Boot] " Tom Rini
2016-01-15 0:53 ` Jeffy Chen
2016-01-15 0:53 ` [U-Boot] " Jeffy Chen
2016-01-15 0:59 ` Tom Rini
2016-01-15 0:59 ` [U-Boot] " Tom Rini
2016-01-15 2:20 ` Jeffy Chen
2016-01-15 2:20 ` [U-Boot] " Jeffy Chen
2016-01-15 14:42 ` Tom Rini
2016-01-15 14:42 ` [U-Boot] " Tom Rini
2016-01-15 15:42 ` Daniel Schwierzeck
2016-01-15 15:42 ` [U-Boot] " Daniel Schwierzeck
2016-01-16 1:18 ` Simon Glass
2016-01-16 1:18 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ1SUJDVPFVXgJjEYgom7tEdaORUAjQ8QfQ8jCpw=NtcJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-22 3:13 ` Simon Glass
2016-01-22 3:13 ` Simon Glass
2016-01-25 16:57 ` Tom Rini
2016-01-25 16:57 ` [U-Boot] " Tom Rini
[not found] ` <5698577B.8040209-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-25 19:07 ` Tom Rini
2016-01-25 19:07 ` Tom Rini
2016-02-02 7:13 ` Jeffy Chen
2016-02-02 7:13 ` [U-Boot] " Jeffy Chen
[not found] ` <56B056FD.70006-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-19 20:55 ` Simon Glass
2016-02-19 20:55 ` Simon Glass
2016-01-13 8:53 ` [PATCH v4 6/6] rockchip: kylin: Check fastboot request Jeffy Chen
2016-01-13 8:53 ` [U-Boot] " Jeffy Chen
[not found] ` <1452675200-15941-7-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-01-13 15:28 ` Tom Rini
2016-01-13 15:28 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5696FE20.6080003@rock-chips.com \
--to=jeffy.chen-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=contact-W9ppeneeCTY@public.gmane.org \
--cc=joe.hershberger-acOepvfBmUk@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=max.krummenacher-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.