From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <tony.luck@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <x86@kernel.org>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit
Date: Thu, 14 Jan 2016 17:13:13 -0600 [thread overview]
Message-ID: <56982B89.6080206@amd.com> (raw)
In-Reply-To: <20160114225842.GM19941@pd.tnic>
On 1/14/2016 4:58 PM, Borislav Petkov wrote:
> On Thu, Jan 14, 2016 at 04:53:58PM -0600, Aravind Gopalakrishnan wrote:
>> Well McaX is name of the field in the MSR. I retained the "SMCA" prefix as
> What does that McaX mean, btw?
McaX indicates-
* we have MCA MSRs in a new address range
* there are more registers per bank (hence the definitions to registers
like MCx_IPID, MCx_CONFIG etc)
>> these are all still part of the ScalableMCA changes.
>> I would prefer if "MCAX" is retained as it is indicative of which bit we are
>> touching. So how about just MCAX_EN_OFF ?
> If we're going to have a bunch of defines belonging to SMCA, then we're
> better having them all start with SMCA_ after all, I guess.
>
> But please make sure you have comments over their definitions explaining
> what those bits are. When an outsider is reading those patches and SMCA,
> MCAX start appearing left and right, his head most likely starts to
> spin.
>
Sure, I shall add some comments around the definitions for V2.
Thanks,
-Aravind.
prev parent reply other threads:[~2016-01-14 23:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 22:05 [PATCH 0/5] Updates to AMD MCE driver per Scalable MCA spec Aravind Gopalakrishnan
2016-01-14 22:05 ` [PATCH 1/5] x86, mce: Fix order of AMD MCE init function call Aravind Gopalakrishnan
2016-01-14 22:05 ` [PATCH 2/5] x86/mcheck/AMD: Do not perform shared bank check for future processors Aravind Gopalakrishnan
2016-01-14 22:05 ` [PATCH 3/5] x86/mcheck/AMD: Reduce number of blocks scanned per bank Aravind Gopalakrishnan
2016-01-14 22:37 ` Borislav Petkov
2016-01-14 22:48 ` Aravind Gopalakrishnan
2016-01-14 22:53 ` Borislav Petkov
2016-01-14 23:08 ` Aravind Gopalakrishnan
2016-01-15 11:14 ` Borislav Petkov
2016-01-15 15:35 ` Gopalakrishnan, Aravind
2016-01-15 16:29 ` Aravind Gopalakrishnan
2016-01-14 22:05 ` [PATCH 4/5] x86/mcheck/AMD: Fix LVT offset configuration for thresholding Aravind Gopalakrishnan
2016-01-14 22:05 ` [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit Aravind Gopalakrishnan
2016-01-14 22:46 ` Borislav Petkov
2016-01-14 22:53 ` Aravind Gopalakrishnan
2016-01-14 22:58 ` Borislav Petkov
2016-01-14 23:13 ` Aravind Gopalakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56982B89.6080206@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.