Re: [Qemu-devel] [PATCH v3 2/2] change type of pci_bridge_initfn() to void

[Cao jin <caoj.fnst@cn.fujitsu.com>]

On 01/14/2016 11:42 PM, Marcel Apfelbaum wrote:
> On 01/14/2016 02:23 PM, Cao jin wrote:


>> diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c
>> index 599768e..e9117b9 100644
>> --- a/hw/pci-host/apb.c
>> +++ b/hw/pci-host/apb.c
>> @@ -636,10 +636,7 @@ static int apb_pci_bridge_initfn(PCIDevice *dev)
>>   {
>>       int rc;
>>
>> -    rc = pci_bridge_initfn(dev, TYPE_PCI_BUS);
>> -    if (rc < 0) {
>> -        return rc;
>> -    }
>> +    pci_bridge_initfn(dev, TYPE_PCI_BUS);
>>
>
> Hi,
>
> It seems you don't need the rc variable here anymore, right?
>
> This should break the build (unused local variable),

Indeed...

> I suggest running configure with no params to check all the architectures,
> (I am also running make check while at it, just to be sure)
>

Thanks for the suggestion, really should that when touched so many device.

> Thanks,
> Marcel
>

> .
>

-- 
Yours Sincerely,

Cao jin