* [PATCH 2/2] Bluetooth: LL privacy allow RPA
@ 2021-04-05 14:30 Sathish Narasimman
2021-04-06 8:50 ` Marcel Holtmann
2021-04-06 14:17 ` Szymon Janc
0 siblings, 2 replies; 4+ messages in thread
From: Sathish Narasimman @ 2021-04-05 14:30 UTC (permalink / raw)
To: linux-bluetooth
Cc: chethan.tumkur.narayan, ravishankar.srivatsa, Sathish Narasimman
allow RPA to add bd address to whitelist
Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
---
net/bluetooth/hci_request.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
index 0d78122342d5..560b74d421a8 100644
--- a/net/bluetooth/hci_request.c
+++ b/net/bluetooth/hci_request.c
@@ -847,6 +847,10 @@ static u8 update_white_list(struct hci_request *req)
*/
bool allow_rpa = hdev->suspended;
+ if (use_ll_privacy(hdev) &&
+ hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
+ allow_rpa = true;
+
/* Go through the current white list programmed into the
* controller one by one and check if that address is still
* in the list of pending connections or list of devices to
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Bluetooth: LL privacy allow RPA
2021-04-05 14:30 [PATCH 2/2] Bluetooth: LL privacy allow RPA Sathish Narasimman
@ 2021-04-06 8:50 ` Marcel Holtmann
2021-04-06 14:17 ` Szymon Janc
1 sibling, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2021-04-06 8:50 UTC (permalink / raw)
To: Sathish Narasimman
Cc: linux-bluetooth, chethan.tumkur.narayan, ravishankar.srivatsa
Hi Sathish,
> allow RPA to add bd address to whitelist
>
> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
> ---
> net/bluetooth/hci_request.c | 4 ++++
> 1 file changed, 4 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Bluetooth: LL privacy allow RPA
2021-04-05 14:30 [PATCH 2/2] Bluetooth: LL privacy allow RPA Sathish Narasimman
2021-04-06 8:50 ` Marcel Holtmann
@ 2021-04-06 14:17 ` Szymon Janc
2021-04-06 15:05 ` Marcel Holtmann
1 sibling, 1 reply; 4+ messages in thread
From: Szymon Janc @ 2021-04-06 14:17 UTC (permalink / raw)
To: linux-bluetooth, Sathish Narasimman
Cc: chethan.tumkur.narayan, ravishankar.srivatsa, Sathish Narasimman
Hi,
On Monday, 5 April 2021 16:30:41 CEST Sathish Narasimman wrote:
> allow RPA to add bd address to whitelist
>
> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
> ---
> net/bluetooth/hci_request.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 0d78122342d5..560b74d421a8 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -847,6 +847,10 @@ static u8 update_white_list(struct hci_request *req)
> */
> bool allow_rpa = hdev->suspended;
>
> + if (use_ll_privacy(hdev) &&
> + hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
> + allow_rpa = true;
> +
> /* Go through the current white list programmed into the
> * controller one by one and check if that address is still
> * in the list of pending connections or list of devices to
I'm bit confused by this patch. Why add RPA to whitelist if LL privacy is in
use?
--
pozdrawiam
Szymon Janc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Bluetooth: LL privacy allow RPA
2021-04-06 14:17 ` Szymon Janc
@ 2021-04-06 15:05 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2021-04-06 15:05 UTC (permalink / raw)
To: Szymon Janc
Cc: linux-bluetooth, Sathish Narasimman, Chethan T N,
ravishankar.srivatsa
Hi Szymon,
>> allow RPA to add bd address to whitelist
>>
>> Signed-off-by: Sathish Narasimman <sathish.narasimman@intel.com>
>> ---
>> net/bluetooth/hci_request.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
>> index 0d78122342d5..560b74d421a8 100644
>> --- a/net/bluetooth/hci_request.c
>> +++ b/net/bluetooth/hci_request.c
>> @@ -847,6 +847,10 @@ static u8 update_white_list(struct hci_request *req)
>> */
>> bool allow_rpa = hdev->suspended;
>>
>> + if (use_ll_privacy(hdev) &&
>> + hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
>> + allow_rpa = true;
>> +
>> /* Go through the current white list programmed into the
>> * controller one by one and check if that address is still
>> * in the list of pending connections or list of devices to
>
> I'm bit confused by this patch. Why add RPA to whitelist if LL privacy is in
> use?
if link layer privacy is enabled and the IRK programmed into the resolving list, we are now allowed to add the device to the white list.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-06 15:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-05 14:30 [PATCH 2/2] Bluetooth: LL privacy allow RPA Sathish Narasimman
2021-04-06 8:50 ` Marcel Holtmann
2021-04-06 14:17 ` Szymon Janc
2021-04-06 15:05 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.