All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mika Penttilä" <mika.penttila@nextfour.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: <linux@arm.linux.org.uk>
Subject: [PATCH] arm: fix incorrect bounds check
Date: Fri, 15 Jan 2016 07:40:56 +0200	[thread overview]
Message-ID: <56988668.1040803@nextfour.com> (raw)

Recent changes (4.4.0+) in module loader triggered oops on ARM. While
investigating it found incorrect bounds check. This was not the cause of
the oops but incorrect anyway.

--Mika

Signed-off-by: mika.penttila@nextfour.com
---

diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c
index cf30daf..be7fe4b 100644
--- a/arch/arm/mm/pageattr.c
+++ b/arch/arm/mm/pageattr.c
@@ -52,7 +52,7 @@ static int change_memory_common(unsigned long addr,
int numpages,
        if (start < MODULES_VADDR || start >= MODULES_END)
                return -EINVAL;

-       if (end < MODULES_VADDR || start >= MODULES_END)
+       if (end < MODULES_VADDR || end >= MODULES_END)
                return -EINVAL;

        data.set_mask = set_mask;

                 reply	other threads:[~2016-01-15  6:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56988668.1040803@nextfour.com \
    --to=mika.penttila@nextfour.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.