All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Duggan <aduggan@synaptics.com>
To: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Stephen Chandler Paul <cpaul@redhat.com>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Chris Healy <cphealy@gmail.com>, Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices
Date: Fri, 15 Jan 2016 11:16:04 -0800	[thread overview]
Message-ID: <56994574.3010002@synaptics.com> (raw)
In-Reply-To: <CAFmnZc3Ce40CT9V8X223aPxfbRXUcRX5RvK=0GitQ5yrPVXhOg@mail.gmail.com>

Hi Audrey,

On 01/15/2016 03:24 AM, Andrey Gusakov wrote:
> On Fri, Jan 15, 2016 at 2:44 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
>> Add devicetree binding for I2C devices and add bindings for optional
>> parameters in the function drivers. Parameters for function drivers are
>> defined in child nodes for each of the functions.
>>
>> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ...
>> +#ifdef CONFIG_OF
>> +static void rmi_function_of_probe(struct rmi_function *fn)
>> +{
>> +       char of_name[8];
>> +
>> +       snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
>> +               fn->fd.function_number);
>> +       fn->dev.of_node = of_find_node_by_name(
>> +                               fn->rmi_dev->xport->dev->of_node, of_name);
>> +}
>>
> Name like "rmi4-f11" including 0 terminator does not fit in 8 chars.
> This leads to the inability to find the correct OF node and get settings.

Oh, I missed that! I'll fix it in the next patch series.

Thanks,
Andrew

> Sorry for previous HTML noise.


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Duggan <aduggan@synaptics.com>
To: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Stephen Chandler Paul <cpaul@redhat.com>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Chris Healy <cphealy@gmail.com>, Rob Herring <robh@kernel.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices
Date: Fri, 15 Jan 2016 11:16:04 -0800	[thread overview]
Message-ID: <56994574.3010002@synaptics.com> (raw)
In-Reply-To: <CAFmnZc3Ce40CT9V8X223aPxfbRXUcRX5RvK=0GitQ5yrPVXhOg@mail.gmail.com>

Hi Audrey,

On 01/15/2016 03:24 AM, Andrey Gusakov wrote:
> On Fri, Jan 15, 2016 at 2:44 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
>> Add devicetree binding for I2C devices and add bindings for optional
>> parameters in the function drivers. Parameters for function drivers are
>> defined in child nodes for each of the functions.
>>
>> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ...
>> +#ifdef CONFIG_OF
>> +static void rmi_function_of_probe(struct rmi_function *fn)
>> +{
>> +       char of_name[8];
>> +
>> +       snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
>> +               fn->fd.function_number);
>> +       fn->dev.of_node = of_find_node_by_name(
>> +                               fn->rmi_dev->xport->dev->of_node, of_name);
>> +}
>>
> Name like "rmi4-f11" including 0 terminator does not fit in 8 chars.
> This leads to the inability to find the correct OF node and get settings.

Oh, I missed that! I'll fix it in the next patch series.

Thanks,
Andrew

> Sorry for previous HTML noise.

  reply	other threads:[~2016-01-15 19:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 23:44 [PATCH v2 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices Andrew Duggan
2016-01-14 23:44 ` Andrew Duggan
2016-01-15 11:20 ` Andrey Gusakov
     [not found] ` <1452815059-22980-1-git-send-email-aduggan-Gq53QDLGkWKakBO8gow8eQ@public.gmane.org>
2016-01-15 11:24   ` Andrey Gusakov
2016-01-15 11:24     ` Andrey Gusakov
2016-01-15 19:16     ` Andrew Duggan [this message]
2016-01-15 19:16       ` Andrew Duggan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56994574.3010002@synaptics.com \
    --to=aduggan@synaptics.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=cheiny@synaptics.com \
    --cc=cpaul@redhat.com \
    --cc=cphealy@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vincent.huang@tw.synaptics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.