All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Duggan <aduggan@synaptics.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Stephen Chandler Paul <cpaul@redhat.com>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Chris Healy <cphealy@gmail.com>,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] Input: DT binding: Change touchscreen to touch for use with touchscreens and touchpads
Date: Fri, 15 Jan 2016 11:20:50 -0800	[thread overview]
Message-ID: <56994692.1040701@synaptics.com> (raw)
In-Reply-To: <20160115032914.GA31562@rob-hp-laptop>

Hi Rob,

On 01/14/2016 07:29 PM, Rob Herring wrote:
> On Thu, Jan 14, 2016 at 03:42:45PM -0800, Andrew Duggan wrote:
>> These generic touchscreen bindings can also be used for touchpads.
>> Instead of creating new generic bindings this patch just renames then to
>> touch-*.
>>
>> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
>> ---
>> It was suggested that for the synaptics-rmi4 driver I use the generic
>> bindings. But, since the rmi4 driver is used for both touchpads and
>> touchscreens it seemed weird to have a touchpad with a parameter
>> of touchscreen-inverted-y. I changed all of the references to it in the
>> source tree. But, I realize this could cause a backwards compatibilty
>> issue with device trees which are not included in the kernel.
> It does and you cannot do this. Live with the weirdness or support both
> names...

Ok, I had a feeling this wouldn't go over well. I guess I'll try living 
with the weirdness for now.

Thanks,
Andrew

> Rob


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Duggan <aduggan@synaptics.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Stephen Chandler Paul <cpaul@redhat.com>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Chris Healy <cphealy@gmail.com>,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH] Input: DT binding: Change touchscreen to touch for use with touchscreens and touchpads
Date: Fri, 15 Jan 2016 11:20:50 -0800	[thread overview]
Message-ID: <56994692.1040701@synaptics.com> (raw)
In-Reply-To: <20160115032914.GA31562@rob-hp-laptop>

Hi Rob,

On 01/14/2016 07:29 PM, Rob Herring wrote:
> On Thu, Jan 14, 2016 at 03:42:45PM -0800, Andrew Duggan wrote:
>> These generic touchscreen bindings can also be used for touchpads.
>> Instead of creating new generic bindings this patch just renames then to
>> touch-*.
>>
>> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
>> ---
>> It was suggested that for the synaptics-rmi4 driver I use the generic
>> bindings. But, since the rmi4 driver is used for both touchpads and
>> touchscreens it seemed weird to have a touchpad with a parameter
>> of touchscreen-inverted-y. I changed all of the references to it in the
>> source tree. But, I realize this could cause a backwards compatibilty
>> issue with device trees which are not included in the kernel.
> It does and you cannot do this. Live with the weirdness or support both
> names...

Ok, I had a feeling this wouldn't go over well. I guess I'll try living 
with the weirdness for now.

Thanks,
Andrew

> Rob

  reply	other threads:[~2016-01-15 19:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 23:42 [PATCH] Input: DT binding: Change touchscreen to touch for use with touchscreens and touchpads Andrew Duggan
2016-01-14 23:42 ` Andrew Duggan
2016-01-15  3:29 ` Rob Herring
2016-01-15 19:20   ` Andrew Duggan [this message]
2016-01-15 19:20     ` Andrew Duggan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56994692.1040701@synaptics.com \
    --to=aduggan@synaptics.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=cheiny@synaptics.com \
    --cc=cpaul@redhat.com \
    --cc=cphealy@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vincent.huang@tw.synaptics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.