All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	richardcochran@gmail.com, Russell King <linux@arm.linux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, nsekhar@ti.com
Subject: Re: [PATCH v3 2/3] ARM: DRA7: add pdata-quirks to do reset of PCIe
Date: Fri, 15 Jan 2016 13:41:38 -0600	[thread overview]
Message-ID: <56994B72.2@ti.com> (raw)
In-Reply-To: <20160115192224.GD3904@atomide.com>

On 01/15/2016 01:22 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [160115 11:20]:
>> On 01/14/2016 08:11 AM, Kishon Vijay Abraham I wrote:
>>> Create platform data for PCIe and populate it with function
>>> pointers to perform assert and deassert of PCIe reset lines.
>>> The PCIe driver can use the callbacks provided here to
>>> reset the PCIe.
>>> This will be removed once the reset contoller driver is
>>> available to reset PCIe.
> ...
> 
>>> +/**
>>> + * struct pci_dra7xx_platform_data - platform data specific to pci in dra7xx
>>> + * @reset_name: name of the reset line
>>> + * @assert_reset: callback for performing assert reset operation
>>> + * @deassert_reset: callback for performing deassert reset operation
>>> + */
>>> +struct pci_dra7xx_platform_data {
>>> +	const char *reset_name;
>>> +
>>> +	int (*assert_reset)(struct platform_device *pdev, const char *name);
>>> +	int (*deassert_reset)(struct platform_device *pdev, const char *name);
>>> +};
> 
> I doubt this platform_data is dra7 specific. I believe it's
> the same PCI controller that has been in the omap variants for
> years?

AFAIK, this only applies to DRA7. Sekhar/Kishon can confirm. I did take
a quick look at OMAP3/4/5 TRMs, and didn't find any. Neither did a grep
on current hwmod files other than DRA7. There's a DM81xx related PCI
clock domain, but don't see any corresponding driver/device for the same.

regards
Suman

WARNING: multiple messages have this Message-ID (diff)
From: s-anna@ti.com (Suman Anna)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] ARM: DRA7: add pdata-quirks to do reset of PCIe
Date: Fri, 15 Jan 2016 13:41:38 -0600	[thread overview]
Message-ID: <56994B72.2@ti.com> (raw)
In-Reply-To: <20160115192224.GD3904@atomide.com>

On 01/15/2016 01:22 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [160115 11:20]:
>> On 01/14/2016 08:11 AM, Kishon Vijay Abraham I wrote:
>>> Create platform data for PCIe and populate it with function
>>> pointers to perform assert and deassert of PCIe reset lines.
>>> The PCIe driver can use the callbacks provided here to
>>> reset the PCIe.
>>> This will be removed once the reset contoller driver is
>>> available to reset PCIe.
> ...
> 
>>> +/**
>>> + * struct pci_dra7xx_platform_data - platform data specific to pci in dra7xx
>>> + * @reset_name: name of the reset line
>>> + * @assert_reset: callback for performing assert reset operation
>>> + * @deassert_reset: callback for performing deassert reset operation
>>> + */
>>> +struct pci_dra7xx_platform_data {
>>> +	const char *reset_name;
>>> +
>>> +	int (*assert_reset)(struct platform_device *pdev, const char *name);
>>> +	int (*deassert_reset)(struct platform_device *pdev, const char *name);
>>> +};
> 
> I doubt this platform_data is dra7 specific. I believe it's
> the same PCI controller that has been in the omap variants for
> years?

AFAIK, this only applies to DRA7. Sekhar/Kishon can confirm. I did take
a quick look at OMAP3/4/5 TRMs, and didn't find any. Neither did a grep
on current hwmod files other than DRA7. There's a DM81xx related PCI
clock domain, but don't see any corresponding driver/device for the same.

regards
Suman

WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>, <richardcochran@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <nsekhar@ti.com>
Subject: Re: [PATCH v3 2/3] ARM: DRA7: add pdata-quirks to do reset of PCIe
Date: Fri, 15 Jan 2016 13:41:38 -0600	[thread overview]
Message-ID: <56994B72.2@ti.com> (raw)
In-Reply-To: <20160115192224.GD3904@atomide.com>

On 01/15/2016 01:22 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [160115 11:20]:
>> On 01/14/2016 08:11 AM, Kishon Vijay Abraham I wrote:
>>> Create platform data for PCIe and populate it with function
>>> pointers to perform assert and deassert of PCIe reset lines.
>>> The PCIe driver can use the callbacks provided here to
>>> reset the PCIe.
>>> This will be removed once the reset contoller driver is
>>> available to reset PCIe.
> ...
> 
>>> +/**
>>> + * struct pci_dra7xx_platform_data - platform data specific to pci in dra7xx
>>> + * @reset_name: name of the reset line
>>> + * @assert_reset: callback for performing assert reset operation
>>> + * @deassert_reset: callback for performing deassert reset operation
>>> + */
>>> +struct pci_dra7xx_platform_data {
>>> +	const char *reset_name;
>>> +
>>> +	int (*assert_reset)(struct platform_device *pdev, const char *name);
>>> +	int (*deassert_reset)(struct platform_device *pdev, const char *name);
>>> +};
> 
> I doubt this platform_data is dra7 specific. I believe it's
> the same PCI controller that has been in the omap variants for
> years?

AFAIK, this only applies to DRA7. Sekhar/Kishon can confirm. I did take
a quick look at OMAP3/4/5 TRMs, and didn't find any. Neither did a grep
on current hwmod files other than DRA7. There's a DM81xx related PCI
clock domain, but don't see any corresponding driver/device for the same.

regards
Suman

  reply	other threads:[~2016-01-15 19:41 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 14:11 [PATCH v3 0/3] dra7xx: get pcie working in mainline Kishon Vijay Abraham I
2016-01-14 14:11 ` Kishon Vijay Abraham I
2016-01-14 14:11 ` Kishon Vijay Abraham I
2016-01-14 14:11 ` [PATCH v3 1/3] ARM: DRA7: hwmod: Add reset data for PCIe Kishon Vijay Abraham I
2016-01-14 14:11   ` Kishon Vijay Abraham I
2016-01-14 14:11   ` Kishon Vijay Abraham I
2016-02-08  1:50   ` Paul Walmsley
2016-02-08  1:50     ` Paul Walmsley
2016-01-14 14:11 ` [PATCH v3 2/3] ARM: DRA7: add pdata-quirks to do reset of PCIe Kishon Vijay Abraham I
2016-01-14 14:11   ` Kishon Vijay Abraham I
2016-01-14 14:11   ` Kishon Vijay Abraham I
2016-01-15 19:19   ` Suman Anna
2016-01-15 19:19     ` Suman Anna
2016-01-15 19:19     ` Suman Anna
2016-01-15 19:22     ` Tony Lindgren
2016-01-15 19:22       ` Tony Lindgren
2016-01-15 19:41       ` Suman Anna [this message]
2016-01-15 19:41         ` Suman Anna
2016-01-15 19:41         ` Suman Anna
2016-01-18  9:12         ` Sekhar Nori
2016-01-18  9:12           ` Sekhar Nori
2016-01-18  9:12           ` Sekhar Nori
2016-01-27 17:23           ` Tony Lindgren
2016-01-27 17:23             ` Tony Lindgren
2016-01-14 14:11 ` [PATCH v3 3/3] pci: dra7xx: use pdata callbacks to perform reset Kishon Vijay Abraham I
2016-01-14 14:11   ` Kishon Vijay Abraham I
2016-01-14 14:11   ` Kishon Vijay Abraham I
2016-01-27 17:31   ` Tony Lindgren
2016-01-27 17:31     ` Tony Lindgren
2016-01-27 18:16     ` Suman Anna
2016-01-27 18:16       ` Suman Anna
2016-01-27 18:16       ` Suman Anna
2016-01-27 18:56       ` Tony Lindgren
2016-01-27 18:56         ` Tony Lindgren
2016-01-27 23:16         ` Suman Anna
2016-01-27 23:16           ` Suman Anna
2016-01-27 23:16           ` Suman Anna
2016-01-28 18:31           ` Tony Lindgren
2016-01-28 18:31             ` Tony Lindgren
2016-01-28 21:15             ` Suman Anna
2016-01-28 21:15               ` Suman Anna
2016-01-28 21:15               ` Suman Anna
2016-02-02 10:40             ` Kishon Vijay Abraham I
2016-02-02 10:40               ` Kishon Vijay Abraham I
2016-02-02 10:40               ` Kishon Vijay Abraham I
2016-02-05  4:19               ` Kishon Vijay Abraham I
2016-02-05  4:19                 ` Kishon Vijay Abraham I
2016-02-05  4:19                 ` Kishon Vijay Abraham I
2016-02-08  2:48               ` Paul Walmsley
2016-02-08  2:48                 ` Paul Walmsley
2016-02-08 20:56                 ` Suman Anna
2016-02-08 20:56                   ` Suman Anna
2016-02-08 20:56                   ` Suman Anna
2016-02-09  8:49                   ` Paul Walmsley
2016-02-09  8:49                     ` Paul Walmsley
2016-02-09 17:40                     ` Suman Anna
2016-02-09 17:40                       ` Suman Anna
2016-02-09 17:40                       ` Suman Anna
2016-02-09 19:36                       ` Paul Walmsley
2016-02-09 19:36                         ` Paul Walmsley
2016-02-10  1:42                         ` Suman Anna
2016-02-10  1:42                           ` Suman Anna
2016-02-10  1:42                           ` Suman Anna
2016-02-10  5:38                           ` Kishon Vijay Abraham I
2016-02-10  5:38                             ` Kishon Vijay Abraham I
2016-02-10  5:38                             ` Kishon Vijay Abraham I
2016-02-11 19:27                             ` Paul Walmsley
2016-02-11 19:27                               ` Paul Walmsley
2016-02-11 22:04                               ` Suman Anna
2016-02-11 22:04                                 ` Suman Anna
2016-02-11 22:04                                 ` Suman Anna
2016-02-12  6:49                               ` Kishon Vijay Abraham I
2016-02-12  6:49                                 ` Kishon Vijay Abraham I
2016-02-12  6:49                                 ` Kishon Vijay Abraham I
2016-02-12 17:20                                 ` Suman Anna
2016-02-12 17:20                                   ` Suman Anna
2016-02-12 17:20                                   ` Suman Anna
2016-02-18 14:21                                   ` Sekhar Nori
2016-02-18 14:21                                     ` Sekhar Nori
2016-02-18 14:21                                     ` Sekhar Nori
2016-02-18 17:23                                     ` Paul Walmsley
2016-02-18 17:23                                       ` Paul Walmsley
2016-02-18 18:27                                       ` Suman Anna
2016-02-18 18:27                                         ` Suman Anna
2016-02-18 18:27                                         ` Suman Anna
2016-02-22  6:18                                     ` Kishon Vijay Abraham I
2016-02-22  6:18                                       ` Kishon Vijay Abraham I
2016-02-22  6:18                                       ` Kishon Vijay Abraham I
2016-02-22  6:31                                       ` Paul Walmsley
2016-02-22  6:31                                         ` Paul Walmsley
2016-02-22  9:55                                         ` Kishon Vijay Abraham I
2016-02-22  9:55                                           ` Kishon Vijay Abraham I
2016-02-22  9:55                                           ` Kishon Vijay Abraham I
2016-02-23 11:57                                           ` Kishon Vijay Abraham I
2016-02-23 11:57                                             ` Kishon Vijay Abraham I
2016-02-23 11:57                                             ` Kishon Vijay Abraham I
2016-02-23 18:28                                             ` Paul Walmsley
2016-02-23 18:28                                               ` Paul Walmsley
2016-02-24  6:21                                               ` Kishon Vijay Abraham I
2016-02-24  6:21                                                 ` Kishon Vijay Abraham I
2016-02-24  6:21                                                 ` Kishon Vijay Abraham I
2016-03-01  8:25                                                 ` Paul Walmsley
2016-03-01  8:25                                                   ` Paul Walmsley
2016-03-01 11:55                                                   ` Kishon Vijay Abraham I
2016-03-01 11:55                                                     ` Kishon Vijay Abraham I
2016-03-01 11:55                                                     ` Kishon Vijay Abraham I
2016-03-01 14:43                                                     ` Bjorn Helgaas
2016-03-01 14:43                                                       ` Bjorn Helgaas
2016-03-01 16:55                                                     ` Suman Anna
2016-03-01 16:55                                                       ` Suman Anna
2016-03-01 16:55                                                       ` Suman Anna
2016-02-11 20:43                             ` Suman Anna
2016-02-11 20:43                               ` Suman Anna
2016-02-11 20:43                               ` Suman Anna
2016-02-12  6:55                               ` Kishon Vijay Abraham I
2016-02-12  6:55                                 ` Kishon Vijay Abraham I
2016-02-12  6:55                                 ` Kishon Vijay Abraham I
2016-02-10  5:36                         ` Kishon Vijay Abraham I
2016-02-10  5:36                           ` Kishon Vijay Abraham I
2016-02-10  5:36                           ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56994B72.2@ti.com \
    --to=s-anna@ti.com \
    --cc=bhelgaas@google.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=richardcochran@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.