All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Ludovic Desroches <ludovic.desroches@atmel.com>,
	nicolas.ferre@atmel.com, alexandre.belloni@free-electrons.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, plagnioj@jcrosoft.com,
	linux-arm-kernel@lists.infradead.org, pmeerw@pmeerw.net,
	robh@kernel.org
Subject: Re: [PATCH v3 3/5] ARM: at91/dt: sama5d2: add adc device
Date: Sat, 16 Jan 2016 11:38:30 +0000	[thread overview]
Message-ID: <569A2BB6.4070602@kernel.org> (raw)
In-Reply-To: <1452785897-16270-4-git-send-email-ludovic.desroches@atmel.com>

On 14/01/16 15:38, Ludovic Desroches wrote:
> Add the ADC device, and remove the adc_op_clk which is useless since the
> adc sampling frequency is configured with sysfs.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
I've now applied the driver to the togreg branch of iio.git.
Should get a pull request out to Greg in about 2 weeks time and it'll
probably be in linux-next a week after that.  I'm assuming all the device
tree changes will got through the at91 tree and arm-soc etc. 
Shout if you want me to take them through IIO.

Thanks,

Jonathan
> ---
>  arch/arm/boot/dts/sama5d2.dtsi | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 3f750f6..46dd430 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -88,12 +88,6 @@
>  			#clock-cells = <0>;
>  			clock-frequency = <0>;
>  		};
> -
> -		adc_op_clk: adc_op_clk{
> -			compatible = "fixed-clock";
> -			#clock-cells = <0>;
> -			clock-frequency = <1000000>;
> -		};
>  	};
>  
>  	ns_sram: sram@00200000 {
> @@ -1085,6 +1079,18 @@
>  				status = "disabled";
>  			};
>  
> +			adc: adc@fc030000 {
> +				compatible = "atmel,sama5d2-adc";
> +				reg = <0xfc030000 0x100>;
> +				interrupts = <40 IRQ_TYPE_LEVEL_HIGH 7>;
> +				clocks = <&adc_clk>;
> +				clock-names = "adc_clk";
> +				atmel,min-sample-rate-hz = <200000>;
> +				atmel,max-sample-rate-hz = <20000000>;
> +				atmel,startup-time-ms = <4>;
> +				status = "disabled";
> +			};
> +
>  			pioA: pinctrl@fc038000 {
>  				compatible = "atmel,sama5d2-pinctrl";
>  				reg = <0xfc038000 0x600>;
> 


WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] ARM: at91/dt: sama5d2: add adc device
Date: Sat, 16 Jan 2016 11:38:30 +0000	[thread overview]
Message-ID: <569A2BB6.4070602@kernel.org> (raw)
In-Reply-To: <1452785897-16270-4-git-send-email-ludovic.desroches@atmel.com>

On 14/01/16 15:38, Ludovic Desroches wrote:
> Add the ADC device, and remove the adc_op_clk which is useless since the
> adc sampling frequency is configured with sysfs.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
I've now applied the driver to the togreg branch of iio.git.
Should get a pull request out to Greg in about 2 weeks time and it'll
probably be in linux-next a week after that.  I'm assuming all the device
tree changes will got through the at91 tree and arm-soc etc. 
Shout if you want me to take them through IIO.

Thanks,

Jonathan
> ---
>  arch/arm/boot/dts/sama5d2.dtsi | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 3f750f6..46dd430 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -88,12 +88,6 @@
>  			#clock-cells = <0>;
>  			clock-frequency = <0>;
>  		};
> -
> -		adc_op_clk: adc_op_clk{
> -			compatible = "fixed-clock";
> -			#clock-cells = <0>;
> -			clock-frequency = <1000000>;
> -		};
>  	};
>  
>  	ns_sram: sram at 00200000 {
> @@ -1085,6 +1079,18 @@
>  				status = "disabled";
>  			};
>  
> +			adc: adc at fc030000 {
> +				compatible = "atmel,sama5d2-adc";
> +				reg = <0xfc030000 0x100>;
> +				interrupts = <40 IRQ_TYPE_LEVEL_HIGH 7>;
> +				clocks = <&adc_clk>;
> +				clock-names = "adc_clk";
> +				atmel,min-sample-rate-hz = <200000>;
> +				atmel,max-sample-rate-hz = <20000000>;
> +				atmel,startup-time-ms = <4>;
> +				status = "disabled";
> +			};
> +
>  			pioA: pinctrl at fc038000 {
>  				compatible = "atmel,sama5d2-pinctrl";
>  				reg = <0xfc038000 0x600>;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ludovic Desroches
	<ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
	nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
	alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
	robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v3 3/5] ARM: at91/dt: sama5d2: add adc device
Date: Sat, 16 Jan 2016 11:38:30 +0000	[thread overview]
Message-ID: <569A2BB6.4070602@kernel.org> (raw)
In-Reply-To: <1452785897-16270-4-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

On 14/01/16 15:38, Ludovic Desroches wrote:
> Add the ADC device, and remove the adc_op_clk which is useless since the
> adc sampling frequency is configured with sysfs.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
I've now applied the driver to the togreg branch of iio.git.
Should get a pull request out to Greg in about 2 weeks time and it'll
probably be in linux-next a week after that.  I'm assuming all the device
tree changes will got through the at91 tree and arm-soc etc. 
Shout if you want me to take them through IIO.

Thanks,

Jonathan
> ---
>  arch/arm/boot/dts/sama5d2.dtsi | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 3f750f6..46dd430 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -88,12 +88,6 @@
>  			#clock-cells = <0>;
>  			clock-frequency = <0>;
>  		};
> -
> -		adc_op_clk: adc_op_clk{
> -			compatible = "fixed-clock";
> -			#clock-cells = <0>;
> -			clock-frequency = <1000000>;
> -		};
>  	};
>  
>  	ns_sram: sram@00200000 {
> @@ -1085,6 +1079,18 @@
>  				status = "disabled";
>  			};
>  
> +			adc: adc@fc030000 {
> +				compatible = "atmel,sama5d2-adc";
> +				reg = <0xfc030000 0x100>;
> +				interrupts = <40 IRQ_TYPE_LEVEL_HIGH 7>;
> +				clocks = <&adc_clk>;
> +				clock-names = "adc_clk";
> +				atmel,min-sample-rate-hz = <200000>;
> +				atmel,max-sample-rate-hz = <20000000>;
> +				atmel,startup-time-ms = <4>;
> +				status = "disabled";
> +			};
> +
>  			pioA: pinctrl@fc038000 {
>  				compatible = "atmel,sama5d2-pinctrl";
>  				reg = <0xfc038000 0x600>;
> 

  reply	other threads:[~2016-01-16 11:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 15:38 [PATCH v3 0/5] Introduce at91_adc8xx driver Ludovic Desroches
2016-01-14 15:38 ` Ludovic Desroches
2016-01-14 15:38 ` Ludovic Desroches
2016-01-14 15:38 ` [PATCH v3 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-16 11:27   ` Jonathan Cameron
2016-01-16 11:27     ` Jonathan Cameron
2016-01-16 11:27     ` Jonathan Cameron
2016-01-16 11:35     ` Jonathan Cameron
2016-01-16 11:35       ` Jonathan Cameron
2016-01-18  7:55       ` Ludovic Desroches
2016-01-18  7:55         ` Ludovic Desroches
2016-01-18  7:55         ` Ludovic Desroches
2016-01-14 15:38 ` [PATCH v3 2/5] MAINTAINERS: add entry for Atmel ADC 8xx driver Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-15  8:54   ` [RESEND PATCH v3 2/5] MAINTAINERS: add entry for Atmel SAMA5D2 ADC driver Ludovic Desroches
2016-01-15  8:54     ` Ludovic Desroches
2016-01-15  8:54     ` Ludovic Desroches
2016-01-14 15:38 ` [PATCH v3 3/5] ARM: at91/dt: sama5d2: add adc device Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-16 11:38   ` Jonathan Cameron [this message]
2016-01-16 11:38     ` Jonathan Cameron
2016-01-16 11:38     ` Jonathan Cameron
2016-01-18  7:59     ` Ludovic Desroches
2016-01-18  7:59       ` Ludovic Desroches
2016-01-18  7:59       ` Ludovic Desroches
2016-01-18  8:09       ` Nicolas Ferre
2016-01-18  8:09         ` Nicolas Ferre
2016-01-18  8:09         ` Nicolas Ferre
2016-01-14 15:38 ` [PATCH v3 4/5] ARM: at91/dt: sama5d2 Xplained: enable the " Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-14 15:38 ` [PATCH v3 5/5] ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches
2016-01-14 15:38   ` Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569A2BB6.4070602@kernel.org \
    --to=jic23@kernel.org \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.