From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
mdroth@linux.vnet.ibm.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld
Date: Mon, 18 Jan 2016 10:51:51 +1100 [thread overview]
Message-ID: <569C2917.9010908@ozlabs.ru> (raw)
In-Reply-To: <1452906886-806-1-git-send-email-david@gibson.dropbear.id.au>
On 01/16/2016 12:14 PM, David Gibson wrote:
> The rtas_ld() and rtas_st() helpers were designed for loading RTAS
> arguments and storing RTAS returns which are in a simple, common array
> format.
>
> However, a number of RTAS routines - and even non-RTAS routines - have
> started using these for accessing other memory buffers, where the
> normal qemu memory access routines would be more appropriate.
>
> This series removes some of these abuses of the RTAS accessors.
imho simple renaming rtas_st to stl_be_phys_real (and so on for other
rtas_xx) would make more sense as rtas_st&co do not have to do anything
with RTAS itself, it is all about realmode guest memory accessб RTAS just
happened to be the first client of it.
btw in st_cc_buf(), what does "cc" stand for?
--
Alexey
next prev parent reply other threads:[~2016-01-17 23:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 1:14 [Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld David Gibson
2016-01-16 1:14 ` [Qemu-devel] [PATCH 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer David Gibson
2016-01-19 2:00 ` Alexey Kardashevskiy
2016-01-19 3:56 ` David Gibson
2016-01-16 1:14 ` [Qemu-devel] [PATCH 2/3] spapr: Remove rtas_st_buffer_direct() David Gibson
2016-01-19 2:07 ` Alexey Kardashevskiy
2016-01-19 4:08 ` David Gibson
2016-01-16 1:14 ` [Qemu-devel] [PATCH 3/3] spapr: Remove abuse of rtas_ld() in h_client_architecture_support David Gibson
2016-01-19 2:08 ` Alexey Kardashevskiy
2016-01-17 23:51 ` Alexey Kardashevskiy [this message]
2016-01-18 1:24 ` [Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569C2917.9010908@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.