From: marc_gonzalez@sigmadesigns.com (Marc Gonzalez)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller
Date: Mon, 18 Jan 2016 16:57:52 +0100 [thread overview]
Message-ID: <569D0B80.1010908@sigmadesigns.com> (raw)
In-Reply-To: <569CE0F2.1060507@sigmadesigns.com>
On 18/01/2016 13:56, Marc Gonzalez wrote:
> For the arch/arm/mach-tango port, I'm using this driver written
> by Mans. Version 1 of the patch was submitted two months ago:
> http://thread.gmane.org/gmane.linux.kernel/2089471
>
> I've tried to address Marc Zyngier's remarks.
And my patch is incomplete, v3 coming right up.
drivers/irqchip/irq-tango.c: In function 'tangox_irq_init':
drivers/irqchip/irq-tango.c:183:6: warning: unused variable 'i' [-Wunused-variable]
int i;
^
drivers/irqchip/irq-tango.c: In function 'tangox_of_irq_init':
drivers/irqchip/irq-tango.c:200:6: warning: 'name' may be used uninitialized in this function [-Wmaybe-uninitialized]
err = irq_alloc_domain_generic_chips(dom, 32, 2, name, handle_level_irq,
^
drivers/irqchip/irq-tango.c:179:14: note: 'name' was declared here
const char *name;
^
Regards.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Mans Rullgard <mans@mansr.com>,
Sebastian Frias <sf84@laposte.net>
Subject: Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller
Date: Mon, 18 Jan 2016 16:57:52 +0100 [thread overview]
Message-ID: <569D0B80.1010908@sigmadesigns.com> (raw)
In-Reply-To: <569CE0F2.1060507@sigmadesigns.com>
On 18/01/2016 13:56, Marc Gonzalez wrote:
> For the arch/arm/mach-tango port, I'm using this driver written
> by Mans. Version 1 of the patch was submitted two months ago:
> http://thread.gmane.org/gmane.linux.kernel/2089471
>
> I've tried to address Marc Zyngier's remarks.
And my patch is incomplete, v3 coming right up.
drivers/irqchip/irq-tango.c: In function 'tangox_irq_init':
drivers/irqchip/irq-tango.c:183:6: warning: unused variable 'i' [-Wunused-variable]
int i;
^
drivers/irqchip/irq-tango.c: In function 'tangox_of_irq_init':
drivers/irqchip/irq-tango.c:200:6: warning: 'name' may be used uninitialized in this function [-Wmaybe-uninitialized]
err = irq_alloc_domain_generic_chips(dom, 32, 2, name, handle_level_irq,
^
drivers/irqchip/irq-tango.c:179:14: note: 'name' was declared here
const char *name;
^
Regards.
next prev parent reply other threads:[~2016-01-18 15:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 12:56 [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez
2016-01-18 12:56 ` Marc Gonzalez
2016-01-18 13:04 ` Måns Rullgård
2016-01-18 13:04 ` Måns Rullgård
2016-01-18 15:57 ` Marc Gonzalez [this message]
2016-01-18 15:57 ` Marc Gonzalez
2016-01-18 16:44 ` [RFC PATCH v3] " Marc Gonzalez
2016-01-18 16:44 ` Marc Gonzalez
2016-01-20 16:04 ` Marc Zyngier
2016-01-20 16:04 ` Marc Zyngier
2016-01-20 16:10 ` Måns Rullgård
2016-01-20 16:10 ` Måns Rullgård
2016-01-20 16:23 ` Marc Zyngier
2016-01-20 16:23 ` Marc Zyngier
2016-01-20 16:25 ` Måns Rullgård
2016-01-20 16:25 ` Måns Rullgård
2016-01-20 16:36 ` Marc Gonzalez
2016-01-20 16:36 ` Marc Gonzalez
2016-01-20 16:38 ` Måns Rullgård
2016-01-20 16:38 ` Måns Rullgård
2016-01-20 16:43 ` Marc Gonzalez
2016-01-20 16:43 ` Marc Gonzalez
2016-01-20 18:09 ` Måns Rullgård
2016-01-20 18:09 ` Måns Rullgård
2016-01-22 15:58 ` Marc Gonzalez
2016-01-22 15:58 ` Marc Gonzalez
2016-01-22 16:35 ` Måns Rullgård
2016-01-22 16:35 ` Måns Rullgård
2016-01-22 16:37 ` Marc Gonzalez
2016-01-22 16:37 ` Marc Gonzalez
2016-01-22 16:39 ` Måns Rullgård
2016-01-22 16:39 ` Måns Rullgård
2016-01-22 16:45 ` Marc Gonzalez
2016-01-22 16:45 ` Marc Gonzalez
2016-01-22 16:49 ` Måns Rullgård
2016-01-22 16:49 ` Måns Rullgård
2016-01-20 16:24 ` Marc Gonzalez
2016-01-20 16:24 ` Marc Gonzalez
2016-01-20 16:26 ` Måns Rullgård
2016-01-20 16:26 ` Måns Rullgård
2016-01-20 17:02 ` Mark Rutland
2016-01-20 17:02 ` Mark Rutland
2016-01-20 17:05 ` Måns Rullgård
2016-01-20 17:05 ` Måns Rullgård
2016-01-20 17:05 ` Marc Gonzalez
2016-01-20 17:05 ` Marc Gonzalez
2016-01-20 17:06 ` Måns Rullgård
2016-01-20 17:06 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D0B80.1010908@sigmadesigns.com \
--to=marc_gonzalez@sigmadesigns.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.