All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] trace: drop trailing empty strings
Date: Mon, 18 Jan 2016 20:37:58 +0300	[thread overview]
Message-ID: <569D22F6.5070104@msgid.tls.msk.ru> (raw)
In-Reply-To: <20160111173036.24764.59878.stgit@bahia.huguette.org>

11.01.2016 20:30, Greg Kurz wrote:

> -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64""
> +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64
...

I'm not sure what's the value of this.  It's fine either way, no?
Do we have a rule for trailing empty strings in coding style? :)

Thanks,

/mjt



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings
Date: Mon, 18 Jan 2016 20:37:58 +0300	[thread overview]
Message-ID: <569D22F6.5070104@msgid.tls.msk.ru> (raw)
In-Reply-To: <20160111173036.24764.59878.stgit@bahia.huguette.org>

11.01.2016 20:30, Greg Kurz wrote:

> -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64""
> +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64
...

I'm not sure what's the value of this.  It's fine either way, no?
Do we have a rule for trailing empty strings in coding style? :)

Thanks,

/mjt

  parent reply	other threads:[~2016-01-18 17:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 17:30 [Qemu-trivial] [PATCH] trace: drop trailing empty strings Greg Kurz
2016-01-11 17:30 ` [Qemu-devel] " Greg Kurz
2016-01-15 17:24 ` [Qemu-trivial] " Eric Blake
2016-01-15 17:24   ` Eric Blake
2016-01-18 17:37 ` Michael Tokarev [this message]
2016-01-18 17:37   ` Michael Tokarev
2016-01-18 18:28   ` [Qemu-trivial] " Greg Kurz
2016-01-18 18:28     ` [Qemu-devel] " Greg Kurz
2016-02-08 15:11     ` [Qemu-trivial] " Stefan Hajnoczi
2016-02-08 15:11       ` Stefan Hajnoczi
2016-02-08 15:39       ` [Qemu-trivial] " Markus Armbruster
2016-02-08 15:39         ` Markus Armbruster
2016-02-09 16:05         ` [Qemu-trivial] " Stefan Hajnoczi
2016-02-09 16:05           ` Stefan Hajnoczi
2016-01-19  7:35 ` [Qemu-trivial] " Markus Armbruster
2016-01-19  7:35   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569D22F6.5070104@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.