From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: ian.campbell@citrix.com, peter.huangpeng@huawei.com,
xen-devel@lists.xen.org, julien.grall@citrix.com,
stefano.stabellini@citrix.com, shannon.zhao@linaro.org
Subject: Re: [PATCH v4 04/10] acpi: Don't do traditional BIOS table scan for ARM64
Date: Tue, 19 Jan 2016 11:46:32 +0800 [thread overview]
Message-ID: <569DB198.700@huawei.com> (raw)
In-Reply-To: <569CF6D102000078000C8062@prv-mh.provo.novell.com>
On 2016/1/18 21:29, Jan Beulich wrote:
>>>> On 16.01.16 at 06:01, <zhaoshenglong@huawei.com> wrote:
>> > --- a/xen/drivers/acpi/tables/tbxfroot.c
>> > +++ b/xen/drivers/acpi/tables/tbxfroot.c
>> > @@ -49,6 +49,12 @@
>> > #define _COMPONENT ACPI_TABLES
>> > ACPI_MODULE_NAME("tbxfroot")
>> >
>> > +#ifdef CONFIG_ARM
>> > +acpi_status __init acpi_find_root_pointer(acpi_native_uint * table_address)
>> > +{
>> > + return_ACPI_STATUS(AE_NOT_FOUND);
>> > +}
>> > +#else
>> > /* Local prototypes */
>> > static u8 *acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length);
>> >
>> > @@ -271,3 +277,4 @@ static u8 *__init acpi_tb_scan_memory_for_rsdp(u8 * start_address, u32 length)
>> > start_address));
>> > return_PTR(NULL);
>> > }
>> > +#endif
> You modify ACPI CA code here, which should be avoided if at all
> possible. Why don't you simply port over Linux'es solution (which
> changes osl.c instead), the more that now we have Linux-like
> Kconfig?
Of course I can and I suggested this way at v3 but ...
Hope this your final suggestion. Thanks in advance!
--
Shannon
next prev parent reply other threads:[~2016-01-19 3:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 5:01 [PATCH v4 00/10] Refactor DT specific codes preparing for ACPI support on ARM64 Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 01/10] ACPI: check acpi_disabled in acpi_table_parse() and acpi_table_parse_entries() Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 02/10] ACPI / table: Add new function to get table entries Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 03/10] acpi/pmstat: Build pmstat for x86 only Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 04/10] acpi: Don't do traditional BIOS table scan for ARM64 Shannon Zhao
2016-01-18 13:29 ` Jan Beulich
2016-01-19 3:46 ` Shannon Zhao [this message]
2016-01-16 5:01 ` [PATCH v4 05/10] acpi: Refactor acpi_os_map_memory to be architecturally independent Shannon Zhao
2016-01-18 13:33 ` Jan Beulich
2016-01-22 8:38 ` Shannon Zhao
2016-01-22 8:47 ` Jan Beulich
2016-01-22 9:37 ` Shannon Zhao
2016-01-22 10:15 ` Jan Beulich
2016-01-22 11:55 ` Shannon Zhao
2016-01-22 12:30 ` Jan Beulich
2016-01-16 5:01 ` [PATCH v4 06/10] arm/smpboot: Move dt specific code in smp to seperate functions Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 07/10] arm/gic-v2: Refactor gicv2_init into generic and dt specific parts Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 08/10] arm/gic-v3: Refactor gicv3_init " Shannon Zhao
2016-01-16 5:01 ` [PATCH v4 09/10] arm/uart: Rename dt-uart.c to arm-uart.c Shannon Zhao
2016-01-18 10:40 ` Jan Beulich
2016-01-19 3:36 ` Shannon Zhao
2016-01-19 8:39 ` Jan Beulich
2016-01-19 8:43 ` Shannon Zhao
2016-01-19 8:50 ` Jan Beulich
2016-01-16 5:01 ` [PATCH v4 10/10] pl011: Refactor pl011 driver to dt and common initialization parts Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569DB198.700@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=peter.huangpeng@huawei.com \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.