From: John Garry <john.garry@huawei.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA
Date: Tue, 19 Jan 2016 09:47:05 +0000 [thread overview]
Message-ID: <569E0619.6020809@huawei.com> (raw)
In-Reply-To: <1452865149-32064-1-git-send-email-geert@linux-m68k.org>
On 15/01/2016 13:39, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_set_mask" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_destroy" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_free" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_supported" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_create" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 37a0c7156087905b..2c05021636a5fea6 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -1,5 +1,6 @@
> config SCSI_HISI_SAS
> tristate "HiSilicon SAS"
> + depends on HAS_DMA
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> help
>
Reviewed-by: John Garry <john.garry@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA
Date: Tue, 19 Jan 2016 09:47:05 +0000 [thread overview]
Message-ID: <569E0619.6020809@huawei.com> (raw)
In-Reply-To: <1452865149-32064-1-git-send-email-geert@linux-m68k.org>
On 15/01/2016 13:39, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_set_mask" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_destroy" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_free" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_supported" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_create" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 37a0c7156087905b..2c05021636a5fea6 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -1,5 +1,6 @@
> config SCSI_HISI_SAS
> tristate "HiSilicon SAS"
> + depends on HAS_DMA
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> help
>
Reviewed-by: John Garry <john.garry@huawei.com>
next prev parent reply other threads:[~2016-01-19 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 13:39 [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA Geert Uytterhoeven
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
2016-01-19 9:56 ` John Garry
2016-01-19 9:56 ` John Garry
2016-01-20 0:25 ` Martin K. Petersen
2016-01-19 9:47 ` John Garry [this message]
2016-01-19 9:47 ` [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA John Garry
2016-01-20 0:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569E0619.6020809@huawei.com \
--to=john.garry@huawei.com \
--cc=JBottomley@odin.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.