* [PATCH] adv7604: fix SPA register location for ADV7612
@ 2016-01-19 12:17 Ulrich Hecht
2016-01-19 12:20 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Hecht @ 2016-01-19 12:17 UTC (permalink / raw)
To: linux-media
Cc: linux-renesas-soc, magnus.damm, laurent.pinchart, hans.verkuil,
ian.molton, lars, william.towle, Ulrich Hecht
SPA location LSB register is at 0x70.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
drivers/media/i2c/adv7604.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 3787f81..f78d36c 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -2149,6 +2149,10 @@ static int adv76xx_set_edid(struct v4l2_subdev *sd, struct v4l2_edid *edid)
if (info->type == ADV7604) {
rep_write(sd, 0x76, spa_loc & 0xff);
rep_write_clr_set(sd, 0x77, 0x40, (spa_loc & 0x100) >> 2);
+ } else if (info->type == ADV7612) {
+ /* ADV7612 Software Manual Rev. A, p. 15 */
+ rep_write(sd, 0x70, spa_loc & 0xff);
+ rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
} else {
/* FIXME: Where is the SPA location LSB register ? */
rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
--
2.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] adv7604: fix SPA register location for ADV7612
2016-01-19 12:17 [PATCH] adv7604: fix SPA register location for ADV7612 Ulrich Hecht
@ 2016-01-19 12:20 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2016-01-19 12:20 UTC (permalink / raw)
To: Ulrich Hecht, linux-media
Cc: linux-renesas-soc, magnus.damm, laurent.pinchart, hans.verkuil,
ian.molton, william.towle
On 01/19/2016 01:17 PM, Ulrich Hecht wrote:
> SPA location LSB register is at 0x70.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> drivers/media/i2c/adv7604.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 3787f81..f78d36c 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -2149,6 +2149,10 @@ static int adv76xx_set_edid(struct v4l2_subdev *sd, struct v4l2_edid *edid)
> if (info->type == ADV7604) {
> rep_write(sd, 0x76, spa_loc & 0xff);
> rep_write_clr_set(sd, 0x77, 0x40, (spa_loc & 0x100) >> 2);
> + } else if (info->type == ADV7612) {
> + /* ADV7612 Software Manual Rev. A, p. 15 */
> + rep_write(sd, 0x70, spa_loc & 0xff);
That should just go onto the else branch and replace the FIXME.
> + rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
> } else {
> /* FIXME: Where is the SPA location LSB register ? */
> rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-19 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-19 12:17 [PATCH] adv7604: fix SPA register location for ADV7612 Ulrich Hecht
2016-01-19 12:20 ` Lars-Peter Clausen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.