From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes
Date: Tue, 19 Jan 2016 13:37:19 +0000 [thread overview]
Message-ID: <569E3C0F.3040603@arm.com> (raw)
In-Reply-To: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com>
On 19/01/16 10:51, Zhong Kaihua wrote:
> arm64: dts: Add Hi6220 gpio configuration nodes
>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> Kong Xinwei <kong.kongxinwei@hisilicon.com>
>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 +
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++
> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++
> 4 files changed, 890 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> new file mode 100644
> index 0000000..a9cbf21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> @@ -0,0 +1,23 @@
> +Hisilicon Hi6220 GPIO controller bindings
> +
> +Required properties:
> + - compatible: "arm,pl061","arm,primecell"
> + - gpio-controller: Marks the device node as a GPIO controller.
> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a
> + description of the cells format.
> + - interrupt-controller: Mark the device node as an interrupt controller
> +
Why do you need extra binding document here as the compatible is same as
[1] ? You can extend that if required and add example there IMO.
--
Regards,
Sudeep
[1] Documentation/devicetree/bindings/gpio/pl061-gpio.txt
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
To: Zhong Kaihua
<zhongkaihua-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
xuyiping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
w.f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org
Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes
Date: Tue, 19 Jan 2016 13:37:19 +0000 [thread overview]
Message-ID: <569E3C0F.3040603@arm.com> (raw)
In-Reply-To: <1453200681-26406-1-git-send-email-zhongkaihua-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On 19/01/16 10:51, Zhong Kaihua wrote:
> arm64: dts: Add Hi6220 gpio configuration nodes
>
> Signed-off-by: Zhong Kaihua <zhongkaihua-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Kong Xinwei <kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 +
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++
> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++
> 4 files changed, 890 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> new file mode 100644
> index 0000000..a9cbf21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> @@ -0,0 +1,23 @@
> +Hisilicon Hi6220 GPIO controller bindings
> +
> +Required properties:
> + - compatible: "arm,pl061","arm,primecell"
> + - gpio-controller: Marks the device node as a GPIO controller.
> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a
> + description of the cells format.
> + - interrupt-controller: Mark the device node as an interrupt controller
> +
Why do you need extra binding document here as the compatible is same as
[1] ? You can extend that if required and add example there IMO.
--
Regards,
Sudeep
[1] Documentation/devicetree/bindings/gpio/pl061-gpio.txt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Zhong Kaihua <zhongkaihua@huawei.com>, robh+dt@kernel.org
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
catalin.marinas@arm.com, will.deacon@arm.com,
xuyiping@hisilicon.com, xuwei5@hisilicon.com,
bintian.wang@huawei.com, haojian.zhuang@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, puck.chen@hisilicon.com,
Sudeep Holla <sudeep.holla@arm.com>,
w.f@huawei.com, dan.zhao@hisilicon.com,
kong.kongxinwei@hisilicon.com
Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes
Date: Tue, 19 Jan 2016 13:37:19 +0000 [thread overview]
Message-ID: <569E3C0F.3040603@arm.com> (raw)
In-Reply-To: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com>
On 19/01/16 10:51, Zhong Kaihua wrote:
> arm64: dts: Add Hi6220 gpio configuration nodes
>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> Kong Xinwei <kong.kongxinwei@hisilicon.com>
>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 +
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++
> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++
> 4 files changed, 890 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> new file mode 100644
> index 0000000..a9cbf21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> @@ -0,0 +1,23 @@
> +Hisilicon Hi6220 GPIO controller bindings
> +
> +Required properties:
> + - compatible: "arm,pl061","arm,primecell"
> + - gpio-controller: Marks the device node as a GPIO controller.
> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a
> + description of the cells format.
> + - interrupt-controller: Mark the device node as an interrupt controller
> +
Why do you need extra binding document here as the compatible is same as
[1] ? You can extend that if required and add example there IMO.
--
Regards,
Sudeep
[1] Documentation/devicetree/bindings/gpio/pl061-gpio.txt
next prev parent reply other threads:[~2016-01-19 13:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:51 [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes Zhong Kaihua
2016-01-19 10:51 ` Zhong Kaihua
2016-01-19 10:51 ` Zhong Kaihua
2016-01-19 10:51 ` [PATCH V3 2/3] arm64: dts: add Hi6220 pinctrl " Zhong Kaihua
2016-01-19 10:51 ` Zhong Kaihua
2016-01-19 10:51 ` Zhong Kaihua
2016-01-19 10:51 ` [PATCH V3 3/3] arm64: dts: add Hi6220 spi " Zhong Kaihua
2016-01-19 10:51 ` Zhong Kaihua
2016-01-19 10:51 ` Zhong Kaihua
2016-01-19 12:25 ` [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio " Wei Xu
2016-01-19 12:25 ` Wei Xu
2016-01-19 12:25 ` Wei Xu
2016-01-19 13:37 ` Sudeep Holla [this message]
2016-01-19 13:37 ` Sudeep Holla
2016-01-19 13:37 ` Sudeep Holla
2016-01-22 8:59 ` Zhong Kaihua
2016-01-22 8:59 ` Zhong Kaihua
2016-01-22 8:59 ` Zhong Kaihua
2016-01-22 9:00 ` 答复: " zhongkaihua
2016-01-22 9:00 ` zhongkaihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569E3C0F.3040603@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.