From: Alim Akhtar <alim.akhtar@samsung.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, k.kozlowski@samsung.com,
devicetree@vger.kernel.org, kgene@kernel.org
Subject: Re: [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} on exynos7
Date: Wed, 20 Jan 2016 08:22:41 +0530 [thread overview]
Message-ID: <569EF679.5040909@samsung.com> (raw)
In-Reply-To: <20160119103224.GA25024@leverpostej>
Hi Mark,
On 01/19/2016 04:02 PM, Mark Rutland wrote:
> On Tue, Jan 19, 2016 at 03:51:24PM +0530, Alim Akhtar wrote:
>> This patch adds cpu-{on,off} function IDs as per PSCI specification,
>> with this we can boot multiple CPUs and can use cpu hotplug on
>> exynos7 platform.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> index f9c5a549c2c0..1a2bb3b453e5 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> @@ -65,6 +65,8 @@
>> psci {
>> compatible = "arm,psci-0.2";
>> method = "smc";
>> + cpu_on = <0xC4000003>;
>> + cpu_off = <0x84000002>;
>> };
>
> There is no need for this patch.
>
> The "arm,psci-0.2" compatible string implicitly tells the kernel that
> the full set of mandatory PSCI 0.2 functions are present, with the IDs
> mandated by PSCI 0.2. That includes CPU_ON and CPU_OFF amongst others.
>
> The only reason to provide IDs is to function on kernels without PSCI
> 0.2 support. Given the compatible string hasn't been updated for that,
> this is insufficient for that case.
>
Ah, right, this patch is not required for psci,0.2, thanks for
clarification.
sorry for the noise.
> Thanks,
> Mark.
>
>
WARNING: multiple messages have this Message-ID (diff)
From: alim.akhtar@samsung.com (Alim Akhtar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} on exynos7
Date: Wed, 20 Jan 2016 08:22:41 +0530 [thread overview]
Message-ID: <569EF679.5040909@samsung.com> (raw)
In-Reply-To: <20160119103224.GA25024@leverpostej>
Hi Mark,
On 01/19/2016 04:02 PM, Mark Rutland wrote:
> On Tue, Jan 19, 2016 at 03:51:24PM +0530, Alim Akhtar wrote:
>> This patch adds cpu-{on,off} function IDs as per PSCI specification,
>> with this we can boot multiple CPUs and can use cpu hotplug on
>> exynos7 platform.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> index f9c5a549c2c0..1a2bb3b453e5 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
>> @@ -65,6 +65,8 @@
>> psci {
>> compatible = "arm,psci-0.2";
>> method = "smc";
>> + cpu_on = <0xC4000003>;
>> + cpu_off = <0x84000002>;
>> };
>
> There is no need for this patch.
>
> The "arm,psci-0.2" compatible string implicitly tells the kernel that
> the full set of mandatory PSCI 0.2 functions are present, with the IDs
> mandated by PSCI 0.2. That includes CPU_ON and CPU_OFF amongst others.
>
> The only reason to provide IDs is to function on kernels without PSCI
> 0.2 support. Given the compatible string hasn't been updated for that,
> this is insufficient for that case.
>
Ah, right, this patch is not required for psci,0.2, thanks for
clarification.
sorry for the noise.
> Thanks,
> Mark.
>
>
next prev parent reply other threads:[~2016-01-20 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:21 [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} on exynos7 Alim Akhtar
2016-01-19 10:21 ` [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on, off} " Alim Akhtar
[not found] ` <1453198884-28723-1-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-01-19 10:32 ` [PATCH] arm64: dts: Add PSCI function IDs for cpu-{on,off} " Mark Rutland
2016-01-19 10:32 ` Mark Rutland
2016-01-20 2:52 ` Alim Akhtar [this message]
2016-01-20 2:52 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EF679.5040909@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.