From: Peter Hung <hpeter@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
gregkh@linuxfoundation.org, jslaby@suse.com,
heikki.krogerus@linux.intel.com, peter@hurleysoftware.com,
soeren.grunewald@desy.de, udknight@gmail.com,
adam.lee@canonical.com, arnd@arndb.de,
yamada.masahiro@socionext.com, mans@mansr.com,
scottwood@freescale.com, paul.burton@imgtec.com,
matthias.bgg@gmail.com, manabian@gmail.com,
peter.ujfalusi@ti.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file
Date: Wed, 20 Jan 2016 10:59:28 +0800 [thread overview]
Message-ID: <569EF810.1000304@gmail.com> (raw)
In-Reply-To: <1453209684.2521.115.camel@linux.intel.com>
Hi Andy, Alan
Andy Shevchenko 於 2016/1/19 下午 09:21 寫道:
>> Your device is multi-function. Create an MFD driver for it. Make the
>> 8250 driver bind to the MFD, and provide your own baud rate methods
>> within the standard 8250 layer
>
> Ouch, somehow I missed this one!
>
> Peter, Alan's suggestion is really worth to try.
>
Thanks for point this. It seems good to probe on MFD driver, them MFD
register platform devices to invoke platform driver to initialize
sub-parts. I'll try to survey first.
But I had a new question, If I really do it with MFD subsystem, it'll
split into 3 parts, MFD probe(driver/mfd) / GPIO (driver/gpio) / UART
(drivers/tty/serial/8250). It'll cross more than 2 subsystems and
maintainers How should I do to organize the patches?
For examples, I should remove the probe function in 8250_pci.c and
move it to new MFD file. It should organize it in the same patch as Paul
said, but this patch will need 2 subsystem maintainer to do with the
same patch, it seems weird.
Andy had cc "[PATCH v5] serial: 8250: add gpio support to exar" to me,
could I use the same way to do GPIOLIB? First add a platform driver
for F81504 gpio and add platform device into 8250_pci.c? It seems to
be good and simple to implement.
--
With Best Regards,
Peter Hung
next prev parent reply other threads:[~2016-01-20 2:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 2:41 [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung
2016-01-19 2:41 ` [PATCH 1/3] serial: 8250_pci: Remove Fintek PCIE UART driver Peter Hung
2016-01-19 2:41 ` [PATCH 2/3] 8250_fintek_pci: Add " Peter Hung
2016-01-19 2:41 ` [PATCH 3/3] 8250_fintek_pci: Add GPIOLIB support Peter Hung
2016-01-19 3:56 ` [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Paul Gortmaker
2016-01-19 3:56 ` Paul Gortmaker
2016-01-19 8:45 ` Peter Hung
2016-01-19 9:33 ` Andy Shevchenko
2016-01-19 12:33 ` One Thousand Gnomes
2016-01-19 13:21 ` Andy Shevchenko
2016-01-20 2:59 ` Peter Hung [this message]
2016-01-20 6:22 ` Sudip Mukherjee
2016-01-20 8:24 ` Peter Hung
2016-01-22 10:53 ` Sudip Mukherjee
2016-01-22 13:44 ` Andy Shevchenko
2016-01-22 13:44 ` Andy Shevchenko
2016-01-29 17:38 ` Sudip Mukherjee
2016-01-29 17:38 ` Sudip Mukherjee
2016-01-29 18:35 ` Andy Shevchenko
2016-01-29 18:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EF810.1000304@gmail.com \
--to=hpeter@gmail.com \
--cc=adam.lee@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter+linux_kernel@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mans@mansr.com \
--cc=matthias.bgg@gmail.com \
--cc=paul.burton@imgtec.com \
--cc=paul.gortmaker@windriver.com \
--cc=peter.ujfalusi@ti.com \
--cc=peter@hurleysoftware.com \
--cc=peter_hong@fintek.com.tw \
--cc=scottwood@freescale.com \
--cc=soeren.grunewald@desy.de \
--cc=udknight@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.