From: Peter Hung <hpeter@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Rob Groner <rgroner@rtd.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
gregkh@linuxfoundation.org, jslaby@suse.com,
heikki.krogerus@linux.intel.com, peter@hurleysoftware.com,
soeren.grunewald@desy.de, udknight@gmail.com,
adam.lee@canonical.com, arnd@arndb.de,
yamada.masahiro@socionext.com, mans@mansr.com,
scottwood@freescale.com, paul.burton@imgtec.com,
matthias.bgg@gmail.com, manabian@gmail.com,
peter.ujfalusi@ti.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file
Date: Wed, 20 Jan 2016 16:24:36 +0800 [thread overview]
Message-ID: <569F4444.3040104@gmail.com> (raw)
In-Reply-To: <20160120062214.GB3747@sudip-pc>
Hi Sudip,
Sudip Mukherjee 於 2016/1/20 下午 02:22 寫道:
> On Wed, Jan 20, 2016 at 10:59:28AM +0800, Peter Hung wrote:
> But my personal opinion, if we move out the serial port related code
> into a new driver (a new Kconfig symbol) userspace of many system will
> break if this new symbol is not enabled by the distributions. But in the
> way I have done the new symbol needs to be enabled only if the user
> wants to use the GPIO capability. If that is not enabled GPIO cannot be
> used but it will never break the serial port related code for them.
> I think we should give a thought to that before splitting out the codes
> from 8250_pci.
I agree with your opinion. I'm trying to implement GPIO with 2 ways,
One is like yours, add platform_device with in 8250_pci.c and implement
GPIOLIB platform driver with in 'driver/gpio", and the other is trying
split out from 8250_pci.c to MFD.
In my personal opinion, the first method is less impact with compatible
old system.
--
With Best Regards,
Peter Hung
next prev parent reply other threads:[~2016-01-20 8:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 2:41 [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Peter Hung
2016-01-19 2:41 ` [PATCH 1/3] serial: 8250_pci: Remove Fintek PCIE UART driver Peter Hung
2016-01-19 2:41 ` [PATCH 2/3] 8250_fintek_pci: Add " Peter Hung
2016-01-19 2:41 ` [PATCH 3/3] 8250_fintek_pci: Add GPIOLIB support Peter Hung
2016-01-19 3:56 ` [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file Paul Gortmaker
2016-01-19 3:56 ` Paul Gortmaker
2016-01-19 8:45 ` Peter Hung
2016-01-19 9:33 ` Andy Shevchenko
2016-01-19 12:33 ` One Thousand Gnomes
2016-01-19 13:21 ` Andy Shevchenko
2016-01-20 2:59 ` Peter Hung
2016-01-20 6:22 ` Sudip Mukherjee
2016-01-20 8:24 ` Peter Hung [this message]
2016-01-22 10:53 ` Sudip Mukherjee
2016-01-22 13:44 ` Andy Shevchenko
2016-01-22 13:44 ` Andy Shevchenko
2016-01-29 17:38 ` Sudip Mukherjee
2016-01-29 17:38 ` Sudip Mukherjee
2016-01-29 18:35 ` Andy Shevchenko
2016-01-29 18:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F4444.3040104@gmail.com \
--to=hpeter@gmail.com \
--cc=adam.lee@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter+linux_kernel@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mans@mansr.com \
--cc=matthias.bgg@gmail.com \
--cc=paul.burton@imgtec.com \
--cc=paul.gortmaker@windriver.com \
--cc=peter.ujfalusi@ti.com \
--cc=peter@hurleysoftware.com \
--cc=peter_hong@fintek.com.tw \
--cc=rgroner@rtd.com \
--cc=scottwood@freescale.com \
--cc=soeren.grunewald@desy.de \
--cc=sudipm.mukherjee@gmail.com \
--cc=udknight@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.