All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
@ 2016-01-14  6:46 Jian Liu
  2016-01-15 18:17 ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Jian Liu @ 2016-01-14  6:46 UTC (permalink / raw)
  To: openembedded-core

If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will cause
error.
  ERROR: linux-libc-headers not found in the base feeds

This is because that there is no linux-libc-headers.rpm generated.

Signed-off-by: Jian Liu <jian.liu@windriver.com>

diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
index 2ba6ed5..403360b 100644
--- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
+++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
@@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
+
+ALLOW_EMPTY_${PN} = "1"


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
  2016-01-14  6:46 [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY Jian Liu
@ 2016-01-15 18:17 ` Richard Purdie
  2016-01-15 18:30   ` Bruce Ashfield
  2016-01-19  3:12   ` Jian Liu
  0 siblings, 2 replies; 6+ messages in thread
From: Richard Purdie @ 2016-01-15 18:17 UTC (permalink / raw)
  To: Jian Liu, openembedded-core

On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
> If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
> cause
> error.
>   ERROR: linux-libc-headers not found in the base feeds
> 
> This is because that there is no linux-libc-headers.rpm generated.

There is no point in generating an empty package just for the sake of
it. Surely you just shouldn't put that in IMAGE_INSTALL?

Cheers,

Richard

> Signed-off-by: Jian Liu <jian.liu@windriver.com>
> 
> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
> -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
> -headers.inc
> index 2ba6ed5..403360b 100644
> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
> ${EXTENDPKGV})"
>  
>  INHIBIT_DEFAULT_DEPS = "1"
>  DEPENDS += "unifdef-native"
> +
> +ALLOW_EMPTY_${PN} = "1"


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
  2016-01-15 18:17 ` Richard Purdie
@ 2016-01-15 18:30   ` Bruce Ashfield
  2016-01-19  3:12   ` Jian Liu
  1 sibling, 0 replies; 6+ messages in thread
From: Bruce Ashfield @ 2016-01-15 18:30 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

On Fri, Jan 15, 2016 at 1:17 PM, Richard Purdie <rpurdie@rpsys.net> wrote:

> On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
> > If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
> > cause
> > error.
> >   ERROR: linux-libc-headers not found in the base feeds
> >
> > This is because that there is no linux-libc-headers.rpm generated.
>
> There is no point in generating an empty package just for the sake of
> it. Surely you just shouldn't put that in IMAGE_INSTALL?
>

Agreed. We can cook up all sorts of invalid/empty package names that
won't work, some things are better simply as a learning experience if
someone tries it :)

Bruce


>
> Cheers,
>
> Richard
>
> > Signed-off-by: Jian Liu <jian.liu@windriver.com>
> >
> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
> > -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
> > -headers.inc
> > index 2ba6ed5..403360b 100644
> > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> > @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
> > ${EXTENDPKGV})"
> >
> >  INHIBIT_DEFAULT_DEPS = "1"
> >  DEPENDS += "unifdef-native"
> > +
> > +ALLOW_EMPTY_${PN} = "1"
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2637 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
  2016-01-15 18:17 ` Richard Purdie
  2016-01-15 18:30   ` Bruce Ashfield
@ 2016-01-19  3:12   ` Jian Liu
  2016-01-19 11:37     ` Martin Jansa
  1 sibling, 1 reply; 6+ messages in thread
From: Jian Liu @ 2016-01-19  3:12 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Bruce Ashfield, openembedded-core



On 2016年01月16日 02:17, Richard Purdie wrote:
> On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
>> If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
>> cause
>> error.
>>    ERROR: linux-libc-headers not found in the base feeds
>>
>> This is because that there is no linux-libc-headers.rpm generated.
> There is no point in generating an empty package just for the sake of
> it. Surely you just shouldn't put that in IMAGE_INSTALL?
>
> Cheers,
>
> Richard

Yes, I submit this patch just considering that someone who is not 
familiar with yocto may be confused
by this behavior. There is linux-libc-headers bb file so IMAGE_INSTALL 
+= "linux-libc-headers" is taken for
granted.

This is really not a bug and it is just a usage problem.

Thanks!

//Jian

>
>> Signed-off-by: Jian Liu <jian.liu@windriver.com>
>>
>> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
>> -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
>> -headers.inc
>> index 2ba6ed5..403360b 100644
>> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>> @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
>> ${EXTENDPKGV})"
>>   
>>   INHIBIT_DEFAULT_DEPS = "1"
>>   DEPENDS += "unifdef-native"
>> +
>> +ALLOW_EMPTY_${PN} = "1"



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
  2016-01-19  3:12   ` Jian Liu
@ 2016-01-19 11:37     ` Martin Jansa
  2016-01-20  5:42       ` Jian Liu
  0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2016-01-19 11:37 UTC (permalink / raw)
  To: Jian Liu; +Cc: Bruce Ashfield, Richard Purdie, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

On Tue, Jan 19, 2016 at 11:12:18AM +0800, Jian Liu wrote:
> 
> 
> On 2016年01月16日 02:17, Richard Purdie wrote:
> > On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
> >> If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
> >> cause
> >> error.
> >>    ERROR: linux-libc-headers not found in the base feeds
> >>
> >> This is because that there is no linux-libc-headers.rpm generated.
> > There is no point in generating an empty package just for the sake of
> > it. Surely you just shouldn't put that in IMAGE_INSTALL?
> >
> > Cheers,
> >
> > Richard
> 
> Yes, I submit this patch just considering that someone who is not 
> familiar with yocto may be confused
> by this behavior. There is linux-libc-headers bb file so IMAGE_INSTALL 
> += "linux-libc-headers" is taken for
> granted.
> 
> This is really not a bug and it is just a usage problem.

And you're making it worse, by allowing such person to install
completely useless empty package assuming that (s)he installed
linux-libc-headers to the image.

Error message is _much_ better than empty useless package.

> >> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
> >> -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
> >> -headers.inc
> >> index 2ba6ed5..403360b 100644
> >> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> >> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> >> @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
> >> ${EXTENDPKGV})"
> >>   
> >>   INHIBIT_DEFAULT_DEPS = "1"
> >>   DEPENDS += "unifdef-native"
> >> +
> >> +ALLOW_EMPTY_${PN} = "1"
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
  2016-01-19 11:37     ` Martin Jansa
@ 2016-01-20  5:42       ` Jian Liu
  0 siblings, 0 replies; 6+ messages in thread
From: Jian Liu @ 2016-01-20  5:42 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Bruce Ashfield, Richard Purdie, openembedded-core



On 2016年01月19日 19:37, Martin Jansa wrote:
> On Tue, Jan 19, 2016 at 11:12:18AM +0800, Jian Liu wrote:
>>
>> On 2016年01月16日 02:17, Richard Purdie wrote:
>>> On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
>>>> If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
>>>> cause
>>>> error.
>>>>     ERROR: linux-libc-headers not found in the base feeds
>>>>
>>>> This is because that there is no linux-libc-headers.rpm generated.
>>> There is no point in generating an empty package just for the sake of
>>> it. Surely you just shouldn't put that in IMAGE_INSTALL?
>>>
>>> Cheers,
>>>
>>> Richard
>> Yes, I submit this patch just considering that someone who is not
>> familiar with yocto may be confused
>> by this behavior. There is linux-libc-headers bb file so IMAGE_INSTALL
>> += "linux-libc-headers" is taken for
>> granted.
>>
>> This is really not a bug and it is just a usage problem.
> And you're making it worse, by allowing such person to install
> completely useless empty package assuming that (s)he installed
> linux-libc-headers to the image.
>
> Error message is _much_ better than empty useless package.
I understand. Thanks a lot.

>
>>>> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
>>>> -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
>>>> -headers.inc
>>>> index 2ba6ed5..403360b 100644
>>>> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>>>> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>>>> @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
>>>> ${EXTENDPKGV})"
>>>>    
>>>>    INHIBIT_DEFAULT_DEPS = "1"
>>>>    DEPENDS += "unifdef-native"
>>>> +
>>>> +ALLOW_EMPTY_${PN} = "1"
>> -- 
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-20  5:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-14  6:46 [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY Jian Liu
2016-01-15 18:17 ` Richard Purdie
2016-01-15 18:30   ` Bruce Ashfield
2016-01-19  3:12   ` Jian Liu
2016-01-19 11:37     ` Martin Jansa
2016-01-20  5:42       ` Jian Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.