All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>,
	Andrey Smetanin <asmetanin@virtuozzo.com>,
	kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>,
	Roman Kagan <rkagan@virtuozzo.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v1] kvm/x86: Hyper-V tsc page setup
Date: Wed, 20 Jan 2016 15:05:13 +0100	[thread overview]
Message-ID: <569F9419.4000601@redhat.com> (raw)
In-Reply-To: <569DEA3B.2040107@openvz.org>



On 19/01/2016 08:48, Denis V. Lunev wrote:
>>
>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>> index 6877b4d7e..93c9e25 100644
>> --- a/include/linux/kvm_host.h
>> +++ b/include/linux/kvm_host.h
>> @@ -145,6 +145,7 @@ static inline bool is_error_page(struct page *page)
>>   #define KVM_REQ_HV_RESET          29
>>   #define KVM_REQ_HV_EXIT           30
>>   #define KVM_REQ_HV_STIMER         31
>> +#define KVM_REQ_HV_TSC_PAGE       32
>>     #define KVM_REQ_MAX               64
>>   
> ping

Applied with this change:

diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
index d7716c6e2752..047c275717d3 100644
--- a/arch/x86/kvm/hyperv.c
+++ b/arch/x86/kvm/hyperv.c
@@ -842,7 +842,7 @@ int kvm_hv_setup_tsc_page(struct kvm_vcpu *vcpu)
 		   tsc_khz, tsc, tsc_scale, tsc_offset);
 
 	tsc_ref.tsc_sequence++;
-	if (tsc_ref.tsc_sequence == 0)
+	if (tsc_ref.tsc_sequence == 0xFFFFFFFF tsc_ref.tsc_sequence == 0)
 		tsc_ref.tsc_sequence = 1;
 
 	tsc_ref.tsc_scale = tsc_scale;

and renumbering KVM_REQ_HV_TSC_PAGE from 32 to 31.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>,
	Andrey Smetanin <asmetanin@virtuozzo.com>,
	kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>,
	Roman Kagan <rkagan@virtuozzo.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup
Date: Wed, 20 Jan 2016 15:05:13 +0100	[thread overview]
Message-ID: <569F9419.4000601@redhat.com> (raw)
In-Reply-To: <569DEA3B.2040107@openvz.org>



On 19/01/2016 08:48, Denis V. Lunev wrote:
>>
>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>> index 6877b4d7e..93c9e25 100644
>> --- a/include/linux/kvm_host.h
>> +++ b/include/linux/kvm_host.h
>> @@ -145,6 +145,7 @@ static inline bool is_error_page(struct page *page)
>>   #define KVM_REQ_HV_RESET          29
>>   #define KVM_REQ_HV_EXIT           30
>>   #define KVM_REQ_HV_STIMER         31
>> +#define KVM_REQ_HV_TSC_PAGE       32
>>     #define KVM_REQ_MAX               64
>>   
> ping

Applied with this change:

diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
index d7716c6e2752..047c275717d3 100644
--- a/arch/x86/kvm/hyperv.c
+++ b/arch/x86/kvm/hyperv.c
@@ -842,7 +842,7 @@ int kvm_hv_setup_tsc_page(struct kvm_vcpu *vcpu)
 		   tsc_khz, tsc, tsc_scale, tsc_offset);
 
 	tsc_ref.tsc_sequence++;
-	if (tsc_ref.tsc_sequence == 0)
+	if (tsc_ref.tsc_sequence == 0xFFFFFFFF tsc_ref.tsc_sequence == 0)
 		tsc_ref.tsc_sequence = 1;
 
 	tsc_ref.tsc_scale = tsc_scale;

and renumbering KVM_REQ_HV_TSC_PAGE from 32 to 31.

Paolo

  reply	other threads:[~2016-01-20 14:05 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-24  9:33 [PATCH v1] kvm/x86: Hyper-V tsc page setup Andrey Smetanin
2015-12-24  9:33 ` [Qemu-devel] " Andrey Smetanin
2016-01-05 21:48 ` Peter Hornyack
2016-01-05 21:48   ` [Qemu-devel] " Peter Hornyack
2016-01-06  9:22   ` Andrey Smetanin
2016-01-06  9:22     ` [Qemu-devel] " Andrey Smetanin
2016-01-12  7:43 ` Andrey Smetanin
2016-01-12  7:43   ` [Qemu-devel] " Andrey Smetanin
2016-01-19  7:48 ` Denis V. Lunev
2016-01-19  7:48   ` [Qemu-devel] " Denis V. Lunev
2016-01-20 14:05   ` Paolo Bonzini [this message]
2016-01-20 14:05     ` Paolo Bonzini
2016-01-20 14:41     ` Andrey Smetanin
2016-01-20 14:41       ` [Qemu-devel] " Andrey Smetanin
2016-01-20 14:44     ` Denis V. Lunev
2016-01-20 14:44       ` [Qemu-devel] " Denis V. Lunev
2016-01-20 14:52       ` Roman Kagan
2016-01-20 14:52         ` [Qemu-devel] " Roman Kagan
2016-01-20 14:54         ` Denis V. Lunev
2016-01-20 14:54           ` [Qemu-devel] " Denis V. Lunev
2016-01-20 21:10         ` Paolo Bonzini
2016-01-20 21:10           ` [Qemu-devel] " Paolo Bonzini
2016-01-22 10:08 ` Paolo Bonzini
2016-01-22 10:08   ` [Qemu-devel] " Paolo Bonzini
2016-01-22 10:15   ` Andrey Smetanin
2016-01-22 10:15     ` [Qemu-devel] " Andrey Smetanin
2016-01-22 11:02     ` Paolo Bonzini
2016-01-22 11:02       ` [Qemu-devel] " Paolo Bonzini
2016-01-22 11:11       ` Andrey Smetanin
2016-01-22 11:11         ` [Qemu-devel] " Andrey Smetanin
2016-01-22 11:31       ` Andrey Smetanin
2016-01-22 11:31         ` [Qemu-devel] " Andrey Smetanin
2016-01-22 11:53         ` Paolo Bonzini
2016-01-22 11:53           ` [Qemu-devel] " Paolo Bonzini
2016-01-22 11:59           ` Andrey Smetanin
2016-01-22 11:59             ` [Qemu-devel] " Andrey Smetanin
2016-01-22 13:13   ` Andrey Smetanin
2016-01-22 13:13     ` [Qemu-devel] " Andrey Smetanin
2016-01-22 13:21     ` Paolo Bonzini
2016-01-22 13:21       ` [Qemu-devel] " Paolo Bonzini
2016-01-22 13:34       ` Andrey Smetanin
2016-01-22 13:34         ` [Qemu-devel] " Andrey Smetanin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569F9419.4000601@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=asmetanin@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.