Re: [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

On 01/19/2016 11:11 PM, Fam Zheng wrote:
> Following patches to refactor and move block dirty bitmap code could use
> this.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  include/block/block.h   | 3 +--
>  include/qemu/typedefs.h | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/block/block.h b/include/block/block.h
> index c96923d..483bfd3 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -8,6 +8,7 @@
>  #include "block/accounting.h"
>  #include "qapi/qmp/qobject.h"
>  #include "qapi-types.h"
> +#include "qemu/hbitmap.h"
>  
>  /* block.c */
>  typedef struct BlockDriver BlockDriver;
> @@ -472,8 +473,6 @@ void *qemu_try_blockalign(BlockDriverState *bs, size_t size);
>  void *qemu_try_blockalign0(BlockDriverState *bs, size_t size);
>  bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov);
>  
> -struct HBitmapIter;

You didn't mention removing this forward declaration in the commit
message, making it look like an accident.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]