From: Dave Hansen <dave@sr71.net>
To: Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
aarcange@redhat.com, n-horiguchi@ah.jp.nec.com, jack@suse.cz
Subject: Re: [PATCH] mm, gup: introduce concept of "foreign" get_user_pages()
Date: Wed, 20 Jan 2016 10:48:33 -0800 [thread overview]
Message-ID: <569FD681.2020808@sr71.net> (raw)
In-Reply-To: <569FCA5A.8040906@suse.cz>
On 01/20/2016 09:56 AM, Vlastimil Babka wrote:
> On 01/20/2016 06:35 PM, Dave Hansen wrote:
>> This also switches get_user_pages_(un)locked() over to be like
>> get_user_pages() and not take a tsk/mm. There is no
>> get_user_pages_foreign_(un)locked(). If someone wants that
>> behavior they just have to use "__" variant and pass in
>> FOLL_FOREIGN explicitly.
>
> Hm so this gets a bit ahead of patch "mm: add gup flag to indicate "foreign" mm
> access", right? It might be cleaner to postpone passing FOLL_FOREIGN until then,
> but not critical.
I've reworded that patch a bit, so it just talks about only enforcing
pkey permissions on non-foreign accesses. I think I'll keep
FOLL_FOREIGN in this patch because it fits in well with the other things
converted to get_user_pages_foreign().
> BTW doesn't that other patch miss passing FOLL_FOREIGN from
> get_user_pages_foreign() or something? I see it only uses it from break_ksm(),
> am I missing something?
Nope. At some point along the way, it got dropped in a merge. Thanks
for catching that! I'll include it in future versions of this patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
aarcange@redhat.com, n-horiguchi@ah.jp.nec.com, jack@suse.cz
Subject: Re: [PATCH] mm, gup: introduce concept of "foreign" get_user_pages()
Date: Wed, 20 Jan 2016 10:48:33 -0800 [thread overview]
Message-ID: <569FD681.2020808@sr71.net> (raw)
In-Reply-To: <569FCA5A.8040906@suse.cz>
On 01/20/2016 09:56 AM, Vlastimil Babka wrote:
> On 01/20/2016 06:35 PM, Dave Hansen wrote:
>> This also switches get_user_pages_(un)locked() over to be like
>> get_user_pages() and not take a tsk/mm. There is no
>> get_user_pages_foreign_(un)locked(). If someone wants that
>> behavior they just have to use "__" variant and pass in
>> FOLL_FOREIGN explicitly.
>
> Hm so this gets a bit ahead of patch "mm: add gup flag to indicate "foreign" mm
> access", right? It might be cleaner to postpone passing FOLL_FOREIGN until then,
> but not critical.
I've reworded that patch a bit, so it just talks about only enforcing
pkey permissions on non-foreign accesses. I think I'll keep
FOLL_FOREIGN in this patch because it fits in well with the other things
converted to get_user_pages_foreign().
> BTW doesn't that other patch miss passing FOLL_FOREIGN from
> get_user_pages_foreign() or something? I see it only uses it from break_ksm(),
> am I missing something?
Nope. At some point along the way, it got dropped in a merge. Thanks
for catching that! I'll include it in future versions of this patch.
next prev parent reply other threads:[~2016-01-20 18:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:35 [PATCH] mm, gup: introduce concept of "foreign" get_user_pages() Dave Hansen
2016-01-20 17:35 ` Dave Hansen
2016-01-20 17:56 ` Vlastimil Babka
2016-01-20 17:56 ` Vlastimil Babka
2016-01-20 18:48 ` Dave Hansen [this message]
2016-01-20 18:48 ` Dave Hansen
2016-01-20 19:30 ` Vlastimil Babka
2016-01-20 19:30 ` Vlastimil Babka
-- strict thread matches above, loose matches on Subject: below --
2016-01-22 18:02 Dave Hansen
2016-01-22 18:02 ` Dave Hansen
2016-01-22 18:16 ` kbuild test robot
2016-01-22 18:16 ` kbuild test robot
2016-01-22 21:31 ` Dave Hansen
2016-01-22 21:31 ` Dave Hansen
2016-01-25 13:17 ` Srikar Dronamraju
2016-01-25 13:17 ` Srikar Dronamraju
2016-01-25 18:18 ` Oleg Nesterov
2016-01-25 18:18 ` Oleg Nesterov
2016-01-27 11:30 ` Vlastimil Babka
2016-01-27 11:30 ` Vlastimil Babka
2016-01-27 22:59 ` Dave Hansen
2016-01-15 18:11 Dave Hansen
2016-01-15 18:11 ` Dave Hansen
2016-01-18 15:20 ` Vlastimil Babka
2016-01-18 15:20 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FD681.2020808@sr71.net \
--to=dave@sr71.net \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.