From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 04/12] fdc: add disk field
Date: Wed, 20 Jan 2016 15:59:30 -0500 [thread overview]
Message-ID: <569FF532.7060203@redhat.com> (raw)
In-Reply-To: <569FEF7F.60206@redhat.com>
On 01/20/2016 03:35 PM, Eric Blake wrote:
> On 01/19/2016 11:51 PM, John Snow wrote:
>> Currently, 'drive' is used both to represent the current diskette
>> type as well as the current drive type.
>>
>> This patch adds a 'disk' field that is updated explicitly to match
>> the type of the disk.
>>
>> As of this patch, disk and drive are always the same, but forthcoming
>> patches to change the behavior of pick_geometry will invalidate this
>> assumption.
>>
>> disk does not need to be migrated because it is not user-visible state
>> nor is it currently used for any calculations. It is purely informative,
>> and will be rebuilt automatically via fd_revalidate on the new host.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> hw/block/fdc.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
Grazie.
--js
next prev parent reply other threads:[~2016-01-20 20:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 6:51 [Qemu-devel] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 01/12] fdc: move pick_geometry John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments John Snow
2016-01-20 20:30 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 03/12] fdc: add drive type qapi enum John Snow
2016-01-20 20:33 ` Eric Blake
2016-01-20 20:49 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 04/12] fdc: add disk field John Snow
2016-01-20 20:35 ` Eric Blake
2016-01-20 20:59 ` John Snow [this message]
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 05/12] fdc: Throw an assertion on misconfigured fd_formats table John Snow
2016-01-20 21:23 ` Eric Blake
2016-01-20 21:33 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 06/12] fdc: add pick_drive John Snow
2016-01-20 22:30 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 07/12] fdc: Add fallback option John Snow
2016-01-20 22:36 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 08/12] fdc: add drive type option John Snow
2016-01-20 22:43 ` Eric Blake
2016-01-20 23:04 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 09/12] fdc: add physical disk sizes John Snow
2016-01-20 22:48 ` Eric Blake
2016-01-20 23:06 ` John Snow
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 10/12] fdc: rework pick_geometry John Snow
2016-01-20 23:45 ` Eric Blake
2016-01-21 20:14 ` John Snow
2016-01-21 20:58 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 11/12] qtest/fdc: Support for 2.88MB drives John Snow
2016-01-21 17:40 ` Eric Blake
2016-01-20 6:51 ` [Qemu-devel] [PATCH v4 12/12] fdc: change auto fallback drive for ISA FDC to 288 John Snow
2016-01-21 17:41 ` Eric Blake
2016-01-20 7:55 ` [Qemu-devel] [Qemu-block] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support Denis V. Lunev
2016-01-20 19:40 ` John Snow
2016-01-20 19:43 ` Denis V. Lunev
2016-01-21 10:53 ` Roman Kagan
2016-01-21 14:59 ` John Snow
2016-01-21 15:37 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FF532.7060203@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.