From: Hannes Reinecke <hare@suse.de>
To: Alexander Duyck <aduyck@mirantis.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, alexander.duyck@gmail.com,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
shane.seymour@hpe.com, jthumshirn@suse.de
Subject: Re: [PATCH 2/2] scsi: Fix RCU handling for VPD pages
Date: Thu, 21 Jan 2016 08:40:17 +0100 [thread overview]
Message-ID: <56A08B61.6070908@suse.de> (raw)
In-Reply-To: <20160121063528.3803.92532.stgit@localhost.localdomain>
On 01/21/2016 07:35 AM, Alexander Duyck wrote:
> This patch is meant to fix the RCU handling for VPD pages. The original
> code had a number of issues including the fact that the local variables
> were being declared as __rcu, the RCU variable being directly accessed
> outside of the RCU locked region, and the fact that length was not
> associated with the data so it would be possible to get a mix and match of
> the length for one VPD page with the data from another.
>
> Fixes: 09e2b0b14690 ("scsi: rescan VPD attributes")
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
> ---
> drivers/scsi/scsi.c | 52 +++++++++++++++++++++++---------------------
> drivers/scsi/scsi_lib.c | 12 +++++-----
> drivers/scsi/scsi_sysfs.c | 14 +++++++-----
> include/scsi/scsi_device.h | 14 ++++++++----
> 4 files changed, 50 insertions(+), 42 deletions(-)
>
Thanks for fixing this up. I didn't really like the two distinct
variables for vpd buffer and length, too, but hadn't thought of
using a struct for here.
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Alexander Duyck <aduyck@mirantis.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, alexander.duyck@gmail.com,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
shane.seymour@hpe.com, jthumshirn@suse.de
Subject: Re: [PATCH 2/2] scsi: Fix RCU handling for VPD pages
Date: Thu, 21 Jan 2016 08:40:17 +0100 [thread overview]
Message-ID: <56A08B61.6070908@suse.de> (raw)
In-Reply-To: <20160121063528.3803.92532.stgit@localhost.localdomain>
On 01/21/2016 07:35 AM, Alexander Duyck wrote:
> This patch is meant to fix the RCU handling for VPD pages. The original
> code had a number of issues including the fact that the local variables
> were being declared as __rcu, the RCU variable being directly accessed
> outside of the RCU locked region, and the fact that length was not
> associated with the data so it would be possible to get a mix and match of
> the length for one VPD page with the data from another.
>
> Fixes: 09e2b0b14690 ("scsi: rescan VPD attributes")
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
> ---
> drivers/scsi/scsi.c | 52 +++++++++++++++++++++++---------------------
> drivers/scsi/scsi_lib.c | 12 +++++-----
> drivers/scsi/scsi_sysfs.c | 14 +++++++-----
> include/scsi/scsi_device.h | 14 ++++++++----
> 4 files changed, 50 insertions(+), 42 deletions(-)
>
Thanks for fixing this up. I didn't really like the two distinct
variables for vpd buffer and length, too, but hadn't thought of
using a struct for here.
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2016-01-21 7:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 6:35 [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads Alexander Duyck
2016-01-21 6:35 ` [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it Alexander Duyck
2016-01-21 7:37 ` Hannes Reinecke
2016-01-21 17:05 ` Alexander Duyck
2016-02-02 1:22 ` Martin K. Petersen
2016-01-21 6:35 ` [PATCH 2/2] scsi: Fix RCU handling for VPD pages Alexander Duyck
2016-01-21 7:40 ` Hannes Reinecke [this message]
2016-01-21 7:40 ` Hannes Reinecke
2016-02-02 10:18 ` [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads Kirill A. Shutemov
2016-02-03 2:45 ` Martin K. Petersen
2016-02-03 6:48 ` Kirill A. Shutemov
2016-02-03 15:27 ` Alexander Duyck
2016-02-04 2:39 ` Martin K. Petersen
2016-02-05 14:54 ` Todd Fujinaka
2016-02-10 2:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A08B61.6070908@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shane.seymour@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.