From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>, Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Thompson <dougthompson@xmission.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] amd64_edac: shift wrapping issue in f1x_get_norm_dct_addr()
Date: Thu, 21 Jan 2016 15:29:55 +0000 [thread overview]
Message-ID: <56A0F973.2040906@amd.com> (raw)
In-Reply-To: <20160121123205.GE21930@pd.tnic>
On 1/21/2016 6:32 AM, Borislav Petkov wrote:
> On Wed, Jan 20, 2016 at 12:54:51PM +0300, Dan Carpenter wrote:
>> + u64 dct_sel_base_off = (u64)(pvt->dct_sel_hi & 0xFFFFFC00) << 16;
>
>
> @Aravind: do you have a box with
>
> setpci -s 18.2 0x114.l
>
> bits [31:16] not 0?
>
>
>
Nope. I don't see it set on my Fam10h and Fam15h Model 00-0fh systems.
But yes, nice catch!
-Aravind.
WARNING: multiple messages have this Message-ID (diff)
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>, Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Thompson <dougthompson@xmission.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] amd64_edac: shift wrapping issue in f1x_get_norm_dct_addr()
Date: Thu, 21 Jan 2016 09:29:55 -0600 [thread overview]
Message-ID: <56A0F973.2040906@amd.com> (raw)
In-Reply-To: <20160121123205.GE21930@pd.tnic>
On 1/21/2016 6:32 AM, Borislav Petkov wrote:
> On Wed, Jan 20, 2016 at 12:54:51PM +0300, Dan Carpenter wrote:
>> + u64 dct_sel_base_off = (u64)(pvt->dct_sel_hi & 0xFFFFFC00) << 16;
>
>
> @Aravind: do you have a box with
>
> setpci -s 18.2 0x114.l
>
> bits [31:16] not 0?
>
>
>
Nope. I don't see it set on my Fam10h and Fam15h Model 00-0fh systems.
But yes, nice catch!
-Aravind.
next prev parent reply other threads:[~2016-01-21 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 9:54 [patch] amd64_edac: shift wrapping issue in f1x_get_norm_dct_addr() Dan Carpenter
2016-01-20 9:54 ` Dan Carpenter
2016-01-21 12:32 ` Borislav Petkov
2016-01-21 12:32 ` Borislav Petkov
2016-01-21 15:29 ` Aravind Gopalakrishnan [this message]
2016-01-21 15:29 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0F973.2040906@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=dougthompson@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.