[PATCH v2] led: core: fix misleading comment after workqueue removal from drivers

[PATCH v2] led: core: fix misleading comment after workqueue removal from drivers

[Heiner Kallweit]

Now that workqueues have been removed from individual drivers and
were replaced with a core-internal workqueue we shouldn't
encourage people to add new workqueues to drivers.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- make comment simpler and clearer
---
 include/linux/leds.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/linux/leds.h b/include/linux/leds.h
index bc1476f..e3470e7 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -49,8 +49,10 @@ struct led_classdev {
 #define LED_SYSFS_DISABLE	(1 << 22)
 #define LED_DEV_CAP_FLASH	(1 << 23)
 
-	/* Set LED brightness level */
-	/* Must not sleep, use a workqueue if needed */
+	/* Set LED brightness level
+	 * Must not sleep. Use brightness_set_blocking for drivers
+	 * that can sleep while setting brightness.
+	 */
 	void		(*brightness_set)(struct led_classdev *led_cdev,
 					  enum led_brightness brightness);
 	/*
-- 
2.7.0

Re: [PATCH v2] led: core: fix misleading comment after workqueue removal from drivers

[Jacek Anaszewski]

Hi Heiner,

Applied to devel branch of LED git. I will merge it to the
for-next branch after merge window is closed.

Thanks,
Jacek Anaszewski

On 01/21/2016 11:11 PM, Heiner Kallweit wrote:
> Now that workqueues have been removed from individual drivers and
> were replaced with a core-internal workqueue we shouldn't
> encourage people to add new workqueues to drivers.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - make comment simpler and clearer
> ---
>   include/linux/leds.h | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index bc1476f..e3470e7 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -49,8 +49,10 @@ struct led_classdev {
>   #define LED_SYSFS_DISABLE	(1 << 22)
>   #define LED_DEV_CAP_FLASH	(1 << 23)
>
> -	/* Set LED brightness level */
> -	/* Must not sleep, use a workqueue if needed */
> +	/* Set LED brightness level
> +	 * Must not sleep. Use brightness_set_blocking for drivers
> +	 * that can sleep while setting brightness.
> +	 */
>   	void		(*brightness_set)(struct led_classdev *led_cdev,
>   					  enum led_brightness brightness);
>   	/*
>