From: Pekka Enberg <penberg@iki.fi>
To: "David Rientjes" <rientjes@google.com>,
"Mika Penttilä" <mika.penttila@nextfour.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust
Date: Fri, 22 Jan 2016 09:13:00 +0200 [thread overview]
Message-ID: <56A1D67C.9080301@iki.fi> (raw)
In-Reply-To: <alpine.DEB.2.10.1601211511230.9813@chino.kir.corp.google.com>
On 01/22/2016 01:12 AM, David Rientjes wrote:
> NACK to your patch as it is just covering up buggy code silently. The
> problem needs to be addressed in change_memory_common() to return if
> there is no size to change (numpages == 0). It's a two line fix to
> that function.
So add a WARN_ON there to *warn* about the situations. There's really no
need to BUG_ON here.
- Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@iki.fi>
To: "David Rientjes" <rientjes@google.com>,
"Mika Penttilä" <mika.penttila@nextfour.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust
Date: Fri, 22 Jan 2016 09:13:00 +0200 [thread overview]
Message-ID: <56A1D67C.9080301@iki.fi> (raw)
In-Reply-To: <alpine.DEB.2.10.1601211511230.9813@chino.kir.corp.google.com>
On 01/22/2016 01:12 AM, David Rientjes wrote:
> NACK to your patch as it is just covering up buggy code silently. The
> problem needs to be addressed in change_memory_common() to return if
> there is no size to change (numpages == 0). It's a two line fix to
> that function.
So add a WARN_ON there to *warn* about the situations. There's really no
need to BUG_ON here.
- Pekka
next prev parent reply other threads:[~2016-01-22 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 5:38 [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust Mika Penttilä
2016-01-21 5:38 ` Mika Penttilä
2016-01-21 23:12 ` David Rientjes
2016-01-21 23:12 ` David Rientjes
2016-01-22 5:39 ` Mika Penttilä
2016-01-22 5:39 ` Mika Penttilä
2016-01-22 7:13 ` Pekka Enberg [this message]
2016-01-22 7:13 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A1D67C.9080301@iki.fi \
--to=penberg@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mika.penttila@nextfour.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.