From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>, linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v2 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length
Date: Fri, 22 Jan 2016 08:43:25 -0300 [thread overview]
Message-ID: <56A215DD.5030904@osg.samsung.com> (raw)
In-Reply-To: <56A1F8BB.9090803@nvidia.com>
Hello Laxman,
Thanks a lot for your feedback and acks.
On 01/22/2016 06:39 AM, Laxman Dewangan wrote:
>
> On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote:
>> It is better to use the ARRAY_SIZE() macro instead of the array length
>> to avoid bugs if the array is later changed and the length not updated.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>
>
> Similar stuffs are there on multiple places:
> u8 data[RTC_NR_TIME];
>
> :::
> ret = regmap_bulk_read(info->max77686->rtc_regmap,
> MAX77686_ALARM1_SEC, data, RTC_NR_TIME);
>
>
> Should we say:
> ret = regmap_bulk_read(info->max77686->rtc_regmap,
> MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data));
>
Very good point, I'll change those on this patch as well for v3.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>, linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length
Date: Fri, 22 Jan 2016 08:43:25 -0300 [thread overview]
Message-ID: <56A215DD.5030904@osg.samsung.com> (raw)
In-Reply-To: <56A1F8BB.9090803@nvidia.com>
Hello Laxman,
Thanks a lot for your feedback and acks.
On 01/22/2016 06:39 AM, Laxman Dewangan wrote:
>
> On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote:
>> It is better to use the ARRAY_SIZE() macro instead of the array length
>> to avoid bugs if the array is later changed and the length not updated.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>
>
> Similar stuffs are there on multiple places:
> u8 data[RTC_NR_TIME];
>
> :::
> ret = regmap_bulk_read(info->max77686->rtc_regmap,
> MAX77686_ALARM1_SEC, data, RTC_NR_TIME);
>
>
> Should we say:
> ret = regmap_bulk_read(info->max77686->rtc_regmap,
> MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data));
>
Very good point, I'll change those on this patch as well for v3.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-01-22 11:43 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 20:23 [rtc-linux] [PATCH v2 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 0:51 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-22 0:51 ` Krzysztof Kozlowski
2016-01-22 9:35 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:35 ` Laxman Dewangan
2016-01-22 9:35 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 0:53 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-22 0:53 ` Krzysztof Kozlowski
2016-01-22 9:39 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:39 ` Laxman Dewangan
2016-01-22 9:39 ` Laxman Dewangan
2016-01-22 11:43 ` Javier Martinez Canillas [this message]
2016-01-22 11:43 ` Javier Martinez Canillas
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 1:02 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-22 1:02 ` Krzysztof Kozlowski
2016-01-22 9:41 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:41 ` Laxman Dewangan
2016-01-22 9:41 ` Laxman Dewangan
2016-01-22 12:05 ` [rtc-linux] " Javier Martinez Canillas
2016-01-22 12:05 ` Javier Martinez Canillas
2016-01-25 11:17 ` [rtc-linux] " Laxman Dewangan
2016-01-25 11:17 ` Laxman Dewangan
2016-01-25 11:17 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 1:00 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-22 1:00 ` Krzysztof Kozlowski
2016-01-22 1:48 ` [rtc-linux] " Javier Martinez Canillas
2016-01-22 1:48 ` Javier Martinez Canillas
2016-01-22 9:50 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:50 ` Laxman Dewangan
2016-01-22 9:50 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 9:52 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:52 ` Laxman Dewangan
2016-01-22 9:52 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 9:54 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:54 ` Laxman Dewangan
2016-01-22 9:54 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 9:56 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:56 ` Laxman Dewangan
2016-01-22 9:56 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 9:59 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:59 ` Laxman Dewangan
2016-01-22 9:59 ` Laxman Dewangan
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-21 20:23 ` [rtc-linux] [PATCH v2 10/10] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-21 20:23 ` Javier Martinez Canillas
2016-01-22 9:57 ` [rtc-linux] " Laxman Dewangan
2016-01-22 9:57 ` Laxman Dewangan
2016-01-22 9:57 ` Laxman Dewangan
2016-01-22 9:57 ` Laxman Dewangan
2016-01-22 12:09 ` [rtc-linux] " Javier Martinez Canillas
2016-01-22 12:09 ` Javier Martinez Canillas
2016-01-22 12:09 ` Javier Martinez Canillas
2016-01-25 16:06 ` [rtc-linux] Re: [PATCH v2 00/10] rtc: max77686: Extend driver and add max77802 support Alexandre Belloni
2016-01-25 16:06 ` Alexandre Belloni
2016-01-25 16:06 ` Alexandre Belloni
2016-01-25 23:45 ` [rtc-linux] " Javier Martinez Canillas
2016-01-25 23:45 ` Javier Martinez Canillas
2016-01-25 23:45 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A215DD.5030904@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.