All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt
@ 2016-01-15  8:30 ` Alexandre Belloni
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2016-01-15  8:30 UTC (permalink / raw)
  To: linux-arm-kernel

No interrupt were received from the phy because PIOE 1 may not be properly
muxed. It prevented proper link detection, especially since commit
321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
disables polling.

Cc: <stable@vger.kernel.org> # 4.4
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 131614f28e75..8cf9999cb0cd 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -86,6 +86,8 @@
 			macb0: ethernet at f8020000 {
 				phy-mode = "rmii";
 				status = "okay";
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
 
 				phy0: ethernet-phy at 1 {
 					interrupt-parent = <&pioE>;
@@ -152,6 +154,10 @@
 						atmel,pins =
 							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
 					};
+					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
+						atmel,pins =
+							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+					};
 				};
 			};
 		};
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt
@ 2016-01-15  8:30 ` Alexandre Belloni
  0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2016-01-15  8:30 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel,
	Alexandre Belloni, stable

No interrupt were received from the phy because PIOE 1 may not be properly
muxed. It prevented proper link detection, especially since commit
321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
disables polling.

Cc: <stable@vger.kernel.org> # 4.4
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 131614f28e75..8cf9999cb0cd 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -86,6 +86,8 @@
 			macb0: ethernet@f8020000 {
 				phy-mode = "rmii";
 				status = "okay";
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
 
 				phy0: ethernet-phy@1 {
 					interrupt-parent = <&pioE>;
@@ -152,6 +154,10 @@
 						atmel,pins =
 							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
 					};
+					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
+						atmel,pins =
+							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+					};
 				};
 			};
 		};
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt
  2016-01-15  8:30 ` Alexandre Belloni
  (?)
@ 2016-01-22 16:12   ` Nicolas Ferre
  -1 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2016-01-22 16:12 UTC (permalink / raw)
  To: linux-arm-kernel

Le 15/01/2016 09:30, Alexandre Belloni a ?crit :
> No interrupt were received from the phy because PIOE 1 may not be properly
> muxed. It prevented proper link detection, especially since commit
> 321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
> disables polling.
> 
> Cc: <stable@vger.kernel.org> # 4.4
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

And added to the upcoming at91-4.5-fixes branch.

thanks!


> ---
>  arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 131614f28e75..8cf9999cb0cd 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -86,6 +86,8 @@
>  			macb0: ethernet at f8020000 {
>  				phy-mode = "rmii";
>  				status = "okay";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
>  
>  				phy0: ethernet-phy at 1 {
>  					interrupt-parent = <&pioE>;
> @@ -152,6 +154,10 @@
>  						atmel,pins =
>  							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
>  					};
> +					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
> +						atmel,pins =
> +							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> +					};
>  				};
>  			};
>  		};
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt
@ 2016-01-22 16:12   ` Nicolas Ferre
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2016-01-22 16:12 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel,
	stable

Le 15/01/2016 09:30, Alexandre Belloni a écrit :
> No interrupt were received from the phy because PIOE 1 may not be properly
> muxed. It prevented proper link detection, especially since commit
> 321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
> disables polling.
> 
> Cc: <stable@vger.kernel.org> # 4.4
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

And added to the upcoming at91-4.5-fixes branch.

thanks!


> ---
>  arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 131614f28e75..8cf9999cb0cd 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -86,6 +86,8 @@
>  			macb0: ethernet@f8020000 {
>  				phy-mode = "rmii";
>  				status = "okay";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
>  
>  				phy0: ethernet-phy@1 {
>  					interrupt-parent = <&pioE>;
> @@ -152,6 +154,10 @@
>  						atmel,pins =
>  							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
>  					};
> +					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
> +						atmel,pins =
> +							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> +					};
>  				};
>  			};
>  		};
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt
@ 2016-01-22 16:12   ` Nicolas Ferre
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2016-01-22 16:12 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel,
	stable

Le 15/01/2016 09:30, Alexandre Belloni a �crit :
> No interrupt were received from the phy because PIOE 1 may not be properly
> muxed. It prevented proper link detection, especially since commit
> 321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
> disables polling.
> 
> Cc: <stable@vger.kernel.org> # 4.4
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

And added to the upcoming at91-4.5-fixes branch.

thanks!


> ---
>  arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 131614f28e75..8cf9999cb0cd 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -86,6 +86,8 @@
>  			macb0: ethernet@f8020000 {
>  				phy-mode = "rmii";
>  				status = "okay";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
>  
>  				phy0: ethernet-phy@1 {
>  					interrupt-parent = <&pioE>;
> @@ -152,6 +154,10 @@
>  						atmel,pins =
>  							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
>  					};
> +					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
> +						atmel,pins =
> +							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> +					};
>  				};
>  			};
>  		};
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-22 16:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15  8:30 [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt Alexandre Belloni
2016-01-15  8:30 ` Alexandre Belloni
2016-01-22 16:12 ` Nicolas Ferre
2016-01-22 16:12   ` Nicolas Ferre
2016-01-22 16:12   ` Nicolas Ferre

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.