All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs
Date: Fri, 22 Jan 2016 17:52:45 +0100	[thread overview]
Message-ID: <56A25E5D.6050504@atmel.com> (raw)
In-Reply-To: <cover.1452867917.git.cyrille.pitchen@atmel.com>

Le 15/01/2016 15:49, Cyrille Pitchen a écrit :
> Hi all,
> 
> This series of patches fixes many issues such as the algo registration failure
> or the broken support of context switches.

I think it's eligible as a "fixes" series for 4.5... Herbert, is the
whole series can be queued as fixes, in your opinion?

And, on the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>


> This series was applied to linux-next and tested on a sama5d2 xplained
> ultra board. We now pass the tcrypt tests in the following modes:
> -  2: sha1
> -  6: sha256
> - 11: sha384
> - 12: sha512
> - 33: sha224
> 
> The context switch fix was tested with a userspace program using the cryptodev
> module. This single thread program computes the SHA256 hashes of many files
> by splitting then into fixed size chunks. The chunks of each file are
> processed by calling 'update' operations using a round robin algorithm.
> 
> However, the .import() / .export() implementation was NOT tested!
> Nonetheless the last patch is needed to fix the registration issue, otherwise
> atmel_sha_probe() would still fail.
> 
> Best regards,
> 
> Cyrille
> 
> 
> Cyrille Pitchen (5):
>   crypto: atmel-sha: fix crash when computing digest on empty message
>   crypto: atmel-sha: fix a race between the 'done' tasklet and the
>     crypto client
>   crypto: atmel-sha: add support of sama5d2x SoCs
>   crypto: atmel-sha: fix context switches
>   crypto: atmel-sha: fix algorihtm registration
> 
>  drivers/crypto/atmel-sha-regs.h |   4 +
>  drivers/crypto/atmel-sha.c      | 186 +++++++++++++++++++++++++++++++++-------
>  2 files changed, 158 insertions(+), 32 deletions(-)
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs
Date: Fri, 22 Jan 2016 17:52:45 +0100	[thread overview]
Message-ID: <56A25E5D.6050504@atmel.com> (raw)
In-Reply-To: <cover.1452867917.git.cyrille.pitchen@atmel.com>

Le 15/01/2016 15:49, Cyrille Pitchen a ?crit :
> Hi all,
> 
> This series of patches fixes many issues such as the algo registration failure
> or the broken support of context switches.

I think it's eligible as a "fixes" series for 4.5... Herbert, is the
whole series can be queued as fixes, in your opinion?

And, on the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>


> This series was applied to linux-next and tested on a sama5d2 xplained
> ultra board. We now pass the tcrypt tests in the following modes:
> -  2: sha1
> -  6: sha256
> - 11: sha384
> - 12: sha512
> - 33: sha224
> 
> The context switch fix was tested with a userspace program using the cryptodev
> module. This single thread program computes the SHA256 hashes of many files
> by splitting then into fixed size chunks. The chunks of each file are
> processed by calling 'update' operations using a round robin algorithm.
> 
> However, the .import() / .export() implementation was NOT tested!
> Nonetheless the last patch is needed to fix the registration issue, otherwise
> atmel_sha_probe() would still fail.
> 
> Best regards,
> 
> Cyrille
> 
> 
> Cyrille Pitchen (5):
>   crypto: atmel-sha: fix crash when computing digest on empty message
>   crypto: atmel-sha: fix a race between the 'done' tasklet and the
>     crypto client
>   crypto: atmel-sha: add support of sama5d2x SoCs
>   crypto: atmel-sha: fix context switches
>   crypto: atmel-sha: fix algorihtm registration
> 
>  drivers/crypto/atmel-sha-regs.h |   4 +
>  drivers/crypto/atmel-sha.c      | 186 +++++++++++++++++++++++++++++++++-------
>  2 files changed, 158 insertions(+), 32 deletions(-)
> 


-- 
Nicolas Ferre

  parent reply	other threads:[~2016-01-22 16:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 14:49 [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Cyrille Pitchen
2016-01-15 14:49 ` Cyrille Pitchen
2016-01-15 14:49 ` [PATCH 1/5] crypto: atmel-sha: fix crash when computing digest on empty message Cyrille Pitchen
2016-01-15 14:49   ` Cyrille Pitchen
2016-01-15 14:49 ` [PATCH 2/5] crypto: atmel-sha: fix a race between the 'done' tasklet and the crypto client Cyrille Pitchen
2016-01-15 14:49   ` Cyrille Pitchen
2016-01-15 14:49 ` [PATCH 3/5] crypto: atmel-sha: add support of sama5d2x SoCs Cyrille Pitchen
2016-01-15 14:49   ` Cyrille Pitchen
2016-01-15 14:49 ` [PATCH 4/5] crypto: atmel-sha: fix context switches Cyrille Pitchen
2016-01-15 14:49   ` Cyrille Pitchen
2016-01-15 14:49 ` [PATCH 5/5] crypto: atmel-sha: fix algorihtm registration Cyrille Pitchen
2016-01-15 14:49   ` Cyrille Pitchen
2016-01-25  7:23   ` Herbert Xu
2016-01-25  7:23     ` Herbert Xu
2016-01-22 16:52 ` Nicolas Ferre [this message]
2016-01-22 16:52   ` [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Nicolas Ferre
2016-01-25  7:25   ` Herbert Xu
2016-01-25  7:25     ` Herbert Xu
2016-01-25 14:48 ` Herbert Xu
2016-01-25 14:48   ` Herbert Xu
2016-01-25 14:56   ` Cyrille Pitchen
2016-01-25 14:56     ` Cyrille Pitchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A25E5D.6050504@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=cyrille.pitchen@atmel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.