From: Doug Goldstein <cardoe@cardoe.com>
To: Chris Patterson <cjp256@gmail.com>,
"McGillion, Brian" <brian.mcgillion@intel.com>
Cc: "meta-virtualization@yoctoproject.org"
<meta-virtualization@yoctoproject.org>
Subject: Re: Failure to build xen-image-minimal
Date: Fri, 22 Jan 2016 19:09:36 -0600 [thread overview]
Message-ID: <56A2D2D0.7060900@cardoe.com> (raw)
In-Reply-To: <CABZSBQeNbXniYMV4PAHrc=MuRMMiNorfbuczmVLjaE3yEnKJuA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On 1/21/16 10:05 AM, Chris Patterson wrote:
> On Thu, Jan 21, 2016 at 10:05 AM, McGillion, Brian
> <brian.mcgillion@intel.com> wrote:
>> Hi Chris,
>>
>> Thank you, that was it!
>>
>> In general should that config not be part of the xen-minimal-image recipe?
>>
>
> The DISTRO_FEATURES is more of a "global" variable and the scope of
> xen-minimal-image is not sufficient to get what you need (in this
> case, affect linux-yocto).
>
> Perhaps we should document in the README?
>
I was thinking we can do something like...
do_check_xen_state() {
if [ "${@bb.utils.contains('DISTRO_FEATURES', 'xen', ' yes', 'no',
d)}" = "no" ]; then
die "DISTRO_FEATURES does not contain 'xen'"
fi
}
addtask check_xen_state before do_rootfs
I can submit a patch.
--
Doug Goldstein
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 978 bytes --]
prev parent reply other threads:[~2016-01-23 1:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 16:11 Failure to build xen-image-minimal McGillion, Brian
2016-01-21 14:12 ` Chris Patterson
2016-01-21 15:05 ` McGillion, Brian
2016-01-21 16:05 ` Chris Patterson
2016-01-23 1:09 ` Doug Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A2D2D0.7060900@cardoe.com \
--to=cardoe@cardoe.com \
--cc=brian.mcgillion@intel.com \
--cc=cjp256@gmail.com \
--cc=meta-virtualization@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.