Re: [PATCH 4/5] scripts/gdb: Add mount point list command

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2016-01-20 12:15, Kieran Bingham wrote:
> lx-mounts will identify current mount points based on the 'init_task'
> namespace by default, as we do not yet have a kernel thread list
> implementation to select the current running thread.
> 
> Optionally, a user can specify a PID to list from that process'
> namespace
> 
> This is somewhat limited vs the /proc/mounts file, as that calls into
> vfs hooks through the s_op functions to obtain extra information.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@linaro.org>
> ---
> 
> 
> In this patch, I'm interested in your opinions on coding styles.
> Would you prefer to see the function helpers, (dentry_name, info_opts) where
> they are, or inside the command as class members? Or perhaps defined in utils?
> 
> This also shows where I need to take constant information from the kernel.
> In this case, they are simple numerical bitflags, and unlikely to change but
> I didn't want to duplicate their values.
> 
> 
>  scripts/gdb/linux/constants.py.in |  21 ++++++++
>  scripts/gdb/linux/proc.py         | 110 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 131 insertions(+)
> 
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index d84084ac945b..739a15d2e984 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -12,7 +12,11 @@
>   *
>   */
>  
> +#include <linux/fs.h>
> +#include <linux/mount.h>
> +
>  /* We need to stringify expanded macros so that they can be parsed */
>  #define STRING(x) #x
>  #define XSTRING(x) STRING(x)
>  

This hunk is malformed, indicating that 4 lines are added while there
are actually only 3 new ones. Could you check what went wrong? I'm
applying it manually for now.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux