All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	mturquette@baylibre.com, lee.jones@linaro.org
Cc: sboyd@codeaurora.org, myungjoo.ham@samsung.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock
Date: Mon, 25 Jan 2016 15:24:13 +0900	[thread overview]
Message-ID: <56A5BF8D.8070807@samsung.com> (raw)
In-Reply-To: <1452252582-20834-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

On 2016=EB=85=84 01=EC=9B=94 08=EC=9D=BC 20:29, Charles Keepax wrote:
> The 32k clock is unconditionally enabled by the MFD core so there is no
> need to control it from the extcon device, so this patch removes the
> control of the 32k clock.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> 
> No changes since v2.
> 
> Thanks,
> Charles
> 
>  drivers/extcon/extcon-arizona.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index e4890dd..52d041f 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1571,7 +1571,6 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>  		goto err_micdet;
>  	}
>  
> -	arizona_clk32k_enable(arizona);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_DEBOUNCE,
>  			   ARIZONA_JD1_DB, ARIZONA_JD1_DB);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE,
> @@ -1642,7 +1641,6 @@ static int arizona_extcon_remove(struct platform_device *pdev)
>  	cancel_delayed_work_sync(&info->hpdet_work);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE,
>  			   ARIZONA_JD1_ENA, 0);
> -	arizona_clk32k_disable(arizona);
>  
>  	return 0;
>  }
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

If I apply only this patch on extcon tree,
the kernel build error will happen on other tree.
I think that this patch will go on clk tree and
then send pull request of immutable branch.

Thanks,
Chanwoo Choi

WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	mturquette@baylibre.com, lee.jones@linaro.org
Cc: sboyd@codeaurora.org, myungjoo.ham@samsung.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock
Date: Mon, 25 Jan 2016 15:24:13 +0900	[thread overview]
Message-ID: <56A5BF8D.8070807@samsung.com> (raw)
In-Reply-To: <1452252582-20834-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

On 2016년 01월 08일 20:29, Charles Keepax wrote:
> The 32k clock is unconditionally enabled by the MFD core so there is no
> need to control it from the extcon device, so this patch removes the
> control of the 32k clock.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> 
> No changes since v2.
> 
> Thanks,
> Charles
> 
>  drivers/extcon/extcon-arizona.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index e4890dd..52d041f 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1571,7 +1571,6 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>  		goto err_micdet;
>  	}
>  
> -	arizona_clk32k_enable(arizona);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_DEBOUNCE,
>  			   ARIZONA_JD1_DB, ARIZONA_JD1_DB);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE,
> @@ -1642,7 +1641,6 @@ static int arizona_extcon_remove(struct platform_device *pdev)
>  	cancel_delayed_work_sync(&info->hpdet_work);
>  	regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE,
>  			   ARIZONA_JD1_ENA, 0);
> -	arizona_clk32k_disable(arizona);
>  
>  	return 0;
>  }
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

If I apply only this patch on extcon tree,
the kernel build error will happen on other tree.
I think that this patch will go on clk tree and
then send pull request of immutable branch.

Thanks,
Chanwoo Choi

  parent reply	other threads:[~2016-01-25  6:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 11:29 [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock Charles Keepax
2016-01-08 11:29 ` Charles Keepax
2016-01-08 11:29 ` [PATCH v3 2/4] clk: arizona: Add clock driver for the Arizona devices Charles Keepax
2016-01-08 11:29   ` Charles Keepax
2016-05-07  0:55   ` Stephen Boyd
2016-05-07  0:55     ` Stephen Boyd
2016-05-09 10:47     ` Charles Keepax
2016-05-09 10:47       ` Charles Keepax
2016-05-09 21:48       ` Stephen Boyd
2016-05-10  9:58         ` Charles Keepax
2016-05-10  9:58           ` Charles Keepax
2016-01-08 11:29 ` [PATCH v3 3/4] mfd: arizona: Switch to using clock driver for 32k clock Charles Keepax
2016-01-08 11:29   ` Charles Keepax
2016-01-11 10:25   ` Lee Jones
2016-01-11 11:03     ` Charles Keepax
2016-01-11 11:03       ` Charles Keepax
2016-05-07  0:55   ` Stephen Boyd
2016-05-09  7:44     ` Lee Jones
2016-05-09 19:34       ` Stephen Boyd
2016-05-10  7:41         ` Lee Jones
2016-01-08 11:29 ` [PATCH v3 4/4] mfd: arizona: Add device tree binding documentation for new clock driver Charles Keepax
2016-01-08 11:29   ` Charles Keepax
2016-01-11 10:23   ` Lee Jones
2016-05-07  0:47   ` Stephen Boyd
2016-05-07  0:49     ` Stephen Boyd
2016-01-25  6:24 ` Chanwoo Choi [this message]
2016-01-25  6:24   ` [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock Chanwoo Choi
2016-05-07  0:50 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A5BF8D.8070807@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.