From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@kernel.org>
Subject: Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date: Mon, 25 Jan 2016 18:10:31 +0900 [thread overview]
Message-ID: <56A5E687.3060209@samsung.com> (raw)
In-Reply-To: <4282078.QlIpNj3Oa6@wuerfel>
On 25.01.2016 17:59, Arnd Bergmann wrote:
> On Monday 25 January 2016 09:50:20 Krzysztof Kozlowski wrote:
>>
>> +# ARM64 SoCs (e.g. Exynos5433, Exynos7):
>> +config EXYNOS_ARM64_COMMON_CLK
>> + def_bool ARCH_EXYNOS
>> + depends on ARM64 || COMPILE_TEST
>> + select COMMON_CLK_SAMSUNG
>>
>
> So you always enable it on ARM64 when ARCH_EXYNOS is enabled, but
> enable it silently on ARM32 when COMPILE_TEST is set?
Hmm... indeed it would better to make it toggle-able when COMPILE_TEST.
> That sounds wrong. How about
>
> config EXYNOS_ARM64_COMMON_CLK
> bool "EXYNOS 64-bit clock support" if COMPILE_TEST
> default ARM64 && ARCH_EXYNOS
> depends on (ARM64 && ARCH_EXYNOS) || COMPILE_TEST
> select COMMON_CLK_SAMSUNG
Although this looks more complicated but it does the trick. Thanks for
the hint. Only one (not related directly to this change) issue - with
COMPILE_TEST the "EXYNOS 64-bit clock support" option goes above the
common clock framework (up to drivers section) because it is not part of
the Clocks menu. I'll fix it in v3.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kevin Hilman <khilman@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Olof Johansson <olof@lixom.net>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date: Mon, 25 Jan 2016 18:10:31 +0900 [thread overview]
Message-ID: <56A5E687.3060209@samsung.com> (raw)
In-Reply-To: <4282078.QlIpNj3Oa6@wuerfel>
On 25.01.2016 17:59, Arnd Bergmann wrote:
> On Monday 25 January 2016 09:50:20 Krzysztof Kozlowski wrote:
>>
>> +# ARM64 SoCs (e.g. Exynos5433, Exynos7):
>> +config EXYNOS_ARM64_COMMON_CLK
>> + def_bool ARCH_EXYNOS
>> + depends on ARM64 || COMPILE_TEST
>> + select COMMON_CLK_SAMSUNG
>>
>
> So you always enable it on ARM64 when ARCH_EXYNOS is enabled, but
> enable it silently on ARM32 when COMPILE_TEST is set?
Hmm... indeed it would better to make it toggle-able when COMPILE_TEST.
> That sounds wrong. How about
>
> config EXYNOS_ARM64_COMMON_CLK
> bool "EXYNOS 64-bit clock support" if COMPILE_TEST
> default ARM64 && ARCH_EXYNOS
> depends on (ARM64 && ARCH_EXYNOS) || COMPILE_TEST
> select COMMON_CLK_SAMSUNG
Although this looks more complicated but it does the trick. Thanks for
the hint. Only one (not related directly to this change) issue - with
COMPILE_TEST the "EXYNOS 64-bit clock support" option goes above the
common clock framework (up to drivers section) because it is not part of
the Clocks menu. I'll fix it in v3.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date: Mon, 25 Jan 2016 18:10:31 +0900 [thread overview]
Message-ID: <56A5E687.3060209@samsung.com> (raw)
In-Reply-To: <4282078.QlIpNj3Oa6@wuerfel>
On 25.01.2016 17:59, Arnd Bergmann wrote:
> On Monday 25 January 2016 09:50:20 Krzysztof Kozlowski wrote:
>>
>> +# ARM64 SoCs (e.g. Exynos5433, Exynos7):
>> +config EXYNOS_ARM64_COMMON_CLK
>> + def_bool ARCH_EXYNOS
>> + depends on ARM64 || COMPILE_TEST
>> + select COMMON_CLK_SAMSUNG
>>
>
> So you always enable it on ARM64 when ARCH_EXYNOS is enabled, but
> enable it silently on ARM32 when COMPILE_TEST is set?
Hmm... indeed it would better to make it toggle-able when COMPILE_TEST.
> That sounds wrong. How about
>
> config EXYNOS_ARM64_COMMON_CLK
> bool "EXYNOS 64-bit clock support" if COMPILE_TEST
> default ARM64 && ARCH_EXYNOS
> depends on (ARM64 && ARCH_EXYNOS) || COMPILE_TEST
> select COMMON_CLK_SAMSUNG
Although this looks more complicated but it does the trick. Thanks for
the hint. Only one (not related directly to this change) issue - with
COMPILE_TEST the "EXYNOS 64-bit clock support" option goes above the
common clock framework (up to drivers section) because it is not part of
the Clocks menu. I'll fix it in v3.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-01-25 9:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 0:50 [RESEND v2 0/2] arm64: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski
2016-01-25 0:50 ` Krzysztof Kozlowski
2016-01-25 0:50 ` [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski
2016-01-25 0:50 ` Krzysztof Kozlowski
2016-01-25 8:59 ` Arnd Bergmann
2016-01-25 8:59 ` Arnd Bergmann
2016-01-25 8:59 ` Arnd Bergmann
2016-01-25 9:10 ` Krzysztof Kozlowski [this message]
2016-01-25 9:10 ` Krzysztof Kozlowski
2016-01-25 9:10 ` Krzysztof Kozlowski
2016-01-25 0:50 ` [RESEND v2 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS Krzysztof Kozlowski
2016-01-25 0:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A5E687.3060209@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.