From: Aleksey Makarov <aleksey.makarov@linaro.org>
To: Joe Perches <joe@perches.com>, linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org,
Graeme Gregory <graeme.gregory@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 1/3] printk: make preferred_console local static bool
Date: Mon, 25 Jan 2016 19:28:52 +0600 [thread overview]
Message-ID: <56A62314.3020803@linaro.org> (raw)
In-Reply-To: <1453728205.28952.62.camel@perches.com>
On 25.01.2016 19:23, Joe Perches wrote:
> On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote:
>>
>> On 25.01.2016 18:45, Joe Perches wrote:
>>> On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote:
>>>> The variable preferred_console is used only inside register_console()
>>>> and it's semantics is boolean. Make it clear.
>>>
>>> This loses the index of the preferred console.
>>> I'm not sure this is better.
>>
>> That index is not used anywhere. I believe the patch makes things clear.
>
> Well, with this change the name and its use
> is a bit misleading. Maybe changing it to
> something like use_selected_console is better.
Thank you. I will fix this in the next version.
WARNING: multiple messages have this Message-ID (diff)
From: aleksey.makarov@linaro.org (Aleksey Makarov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] printk: make preferred_console local static bool
Date: Mon, 25 Jan 2016 19:28:52 +0600 [thread overview]
Message-ID: <56A62314.3020803@linaro.org> (raw)
In-Reply-To: <1453728205.28952.62.camel@perches.com>
On 25.01.2016 19:23, Joe Perches wrote:
> On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote:
>>
>> On 25.01.2016 18:45, Joe Perches wrote:
>>> On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote:
>>>> The variable preferred_console is used only inside register_console()
>>>> and it's semantics is boolean. Make it clear.
>>>
>>> This loses the index of the preferred console.
>>> I'm not sure this is better.
>>
>> That index is not used anywhere. I believe the patch makes things clear.
>
> Well, with this change the name and its use
> is a bit misleading. Maybe changing it to
> something like use_selected_console is better.
Thank you. I will fix this in the next version.
next prev parent reply other threads:[~2016-01-25 13:28 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:45 [PATCH 0/3] ACPI: parse the SPCR table Aleksey Makarov
2016-01-25 11:45 ` Aleksey Makarov
2016-01-25 11:45 ` [PATCH 1/3] printk: make preferred_console local static bool Aleksey Makarov
2016-01-25 11:45 ` Aleksey Makarov
2016-01-25 12:45 ` Joe Perches
2016-01-25 12:45 ` Joe Perches
2016-01-25 12:45 ` Joe Perches
2016-01-25 12:51 ` Aleksey Makarov
2016-01-25 12:51 ` Aleksey Makarov
2016-01-25 13:23 ` Joe Perches
2016-01-25 13:23 ` Joe Perches
2016-01-25 13:23 ` Joe Perches
2016-01-25 13:28 ` Aleksey Makarov [this message]
2016-01-25 13:28 ` Aleksey Makarov
2016-01-25 16:14 ` Peter Hurley
2016-01-25 16:14 ` Peter Hurley
2016-01-25 14:24 ` Andy Shevchenko
2016-01-25 14:24 ` Andy Shevchenko
2016-01-25 14:55 ` Aleksey Makarov
2016-01-25 14:55 ` Aleksey Makarov
2016-01-25 11:45 ` [PATCH 2/3] ACPI: parse SPCR and enable matching console Aleksey Makarov
2016-01-25 11:45 ` Aleksey Makarov
2016-01-25 14:14 ` Andy Shevchenko
2016-01-25 14:14 ` Andy Shevchenko
2016-01-25 15:07 ` Aleksey Makarov
2016-01-25 15:07 ` Aleksey Makarov
2016-01-25 16:32 ` Peter Hurley
2016-01-25 16:32 ` Peter Hurley
2016-01-27 13:57 ` Aleksey Makarov
2016-01-27 13:57 ` Aleksey Makarov
2016-01-28 0:45 ` Peter Hurley
2016-01-28 0:45 ` Peter Hurley
2016-01-28 13:23 ` Aleksey Makarov
2016-01-28 13:23 ` Aleksey Makarov
2016-01-28 19:40 ` Peter Hurley
2016-01-28 19:40 ` Peter Hurley
2016-02-01 9:01 ` Graeme Gregory
2016-02-01 9:01 ` Graeme Gregory
2016-02-01 9:13 ` Graeme Gregory
2016-02-01 9:13 ` Graeme Gregory
2016-01-25 11:45 ` [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c Aleksey Makarov
2016-01-25 11:45 ` Aleksey Makarov
2016-01-25 14:21 ` Andy Shevchenko
2016-01-25 14:21 ` Andy Shevchenko
2016-01-25 14:22 ` Andy Shevchenko
2016-01-25 14:22 ` Andy Shevchenko
2016-01-25 15:08 ` Aleksey Makarov
2016-01-25 15:08 ` Aleksey Makarov
2016-01-25 16:11 ` [PATCH 0/3] ACPI: parse the SPCR table Peter Hurley
2016-01-25 16:11 ` Peter Hurley
2016-01-27 12:17 ` Aleksey Makarov
2016-01-27 12:17 ` Aleksey Makarov
2016-01-27 12:17 ` Aleksey Makarov
2016-01-27 13:45 ` One Thousand Gnomes
2016-01-27 13:45 ` One Thousand Gnomes
2016-01-27 13:45 ` One Thousand Gnomes
2016-02-01 5:46 ` Jon Masters
2016-02-01 5:46 ` Jon Masters
2016-02-01 5:46 ` Jon Masters
2016-02-10 23:39 ` Al Stone
2016-02-10 23:39 ` Al Stone
2016-03-03 20:08 ` Peter Hurley
2016-03-03 20:08 ` Peter Hurley
2016-03-03 20:08 ` Peter Hurley
[not found] ` <67709E22-E82E-40BA-A271-2107608F4EF3@redhat.com>
2016-03-04 19:34 ` Peter Hurley
2016-03-04 19:34 ` Peter Hurley
2016-03-04 20:03 ` Peter Hurley
2016-03-04 20:03 ` Peter Hurley
2016-03-04 20:03 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A62314.3020803@linaro.org \
--to=aleksey.makarov@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.