From: John Crispin <blogic@openwrt.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Mark Brown <broonie@kernel.org>,
Steven Liu <steven.liu@mediatek.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Henry Chen <henryc.chen@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Chen Zhong <chen.zhong@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Mon, 25 Jan 2016 15:02:55 +0100 [thread overview]
Message-ID: <56A62B0F.2090707@openwrt.org> (raw)
In-Reply-To: <CABxcv==VGNyS2ukCGLoYM9OPbTWjQ3jOvCa-HAVMv3whDcnStg@mail.gmail.com>
On 25/01/2016 15:01, Javier Martinez Canillas wrote:
> Hello John,
>
> On Mon, Jan 25, 2016 at 10:46 AM, John Crispin <blogic@openwrt.org> wrote:
>>
>>
>> On 25/01/2016 14:25, Javier Martinez Canillas wrote:
>>> On Mon, Jan 25, 2016 at 10:19 AM, Javier Martinez Canillas
>>> <javier@dowhile0.org> wrote:
>>>
>>> [snip]
>>>
>>>>
>>>> In fact, the kernel is currently not matching the compatible, it is
>>>> only matching because you provided a .of_compatible is provided in the
>>>> mfd_cell.
>>>>
>>>
>>> Sorry my English was a bit off in this paragraph...
>>>
>>> I tried to say that OF does not traverse MFD sub-devices and lookups a
>>> device driver that matches the compatible automatically since a MFD
>>> device is not a bus. Currently it is only trying to match a compatible
>>> string because the mfd_cell has a .of_compatible set so an of_node is
>>> assigned on mfd_add_device().
>>>
>>> But it is failing to match because no OF device table is provided and
>>> the platform bus match callback is falling back to the driver .name to
>>> match so the compatible is not really used as Mark said.
>>>
>>> Best regards,
>>> Javier
>>>
>>
>> Hi,
>>
>> just so i am sure to have understood properly. i just need to drop the
>> compatible string from [1/2] and resend. if this is the case i will fix
>> the mt6397 binding doc while at it.
>>
>
> And you will also need to remove the .of_compatible =
> "mediatek,mt6323-regulator" from patch "[PATCH V2 4/4] mfd: mediatek:
> add MT6323 support to MT6397 driver" since otherwise an
> MODALIAS=of:foo will be reported instead of an MODALIAS=platform:foo
>
> But if I were you, I would keep the MFD driver and DT binding as they
> are and provide a .id_table and .of_match_table to the mt6323
> regulator platform driver.
>
> I'll write patches for the mt6397 regulator driver adding those tables
> since it has the same issue and you can see what I mean.
>
>> John
>
> Best regards,
> Javier
>
Hi Javier,
fine i'll do that then. thanks for the elaborate explanation.
John
WARNING: multiple messages have this Message-ID (diff)
From: blogic@openwrt.org (John Crispin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Mon, 25 Jan 2016 15:02:55 +0100 [thread overview]
Message-ID: <56A62B0F.2090707@openwrt.org> (raw)
In-Reply-To: <CABxcv==VGNyS2ukCGLoYM9OPbTWjQ3jOvCa-HAVMv3whDcnStg@mail.gmail.com>
On 25/01/2016 15:01, Javier Martinez Canillas wrote:
> Hello John,
>
> On Mon, Jan 25, 2016 at 10:46 AM, John Crispin <blogic@openwrt.org> wrote:
>>
>>
>> On 25/01/2016 14:25, Javier Martinez Canillas wrote:
>>> On Mon, Jan 25, 2016 at 10:19 AM, Javier Martinez Canillas
>>> <javier@dowhile0.org> wrote:
>>>
>>> [snip]
>>>
>>>>
>>>> In fact, the kernel is currently not matching the compatible, it is
>>>> only matching because you provided a .of_compatible is provided in the
>>>> mfd_cell.
>>>>
>>>
>>> Sorry my English was a bit off in this paragraph...
>>>
>>> I tried to say that OF does not traverse MFD sub-devices and lookups a
>>> device driver that matches the compatible automatically since a MFD
>>> device is not a bus. Currently it is only trying to match a compatible
>>> string because the mfd_cell has a .of_compatible set so an of_node is
>>> assigned on mfd_add_device().
>>>
>>> But it is failing to match because no OF device table is provided and
>>> the platform bus match callback is falling back to the driver .name to
>>> match so the compatible is not really used as Mark said.
>>>
>>> Best regards,
>>> Javier
>>>
>>
>> Hi,
>>
>> just so i am sure to have understood properly. i just need to drop the
>> compatible string from [1/2] and resend. if this is the case i will fix
>> the mt6397 binding doc while at it.
>>
>
> And you will also need to remove the .of_compatible =
> "mediatek,mt6323-regulator" from patch "[PATCH V2 4/4] mfd: mediatek:
> add MT6323 support to MT6397 driver" since otherwise an
> MODALIAS=of:foo will be reported instead of an MODALIAS=platform:foo
>
> But if I were you, I would keep the MFD driver and DT binding as they
> are and provide a .id_table and .of_match_table to the mt6323
> regulator platform driver.
>
> I'll write patches for the mt6397 regulator driver adding those tables
> since it has the same issue and you can see what I mean.
>
>> John
>
> Best regards,
> Javier
>
Hi Javier,
fine i'll do that then. thanks for the elaborate explanation.
John
next prev parent reply other threads:[~2016-01-25 14:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 10:40 [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator John Crispin
2016-01-25 10:40 ` John Crispin
2016-01-25 10:40 ` [PATCH V2 2/2] regulator: mt6323: Add support " John Crispin
2016-01-25 10:40 ` John Crispin
2016-01-25 12:11 ` Javier Martinez Canillas
2016-01-25 12:11 ` Javier Martinez Canillas
2016-01-25 12:19 ` John Crispin
2016-01-25 12:19 ` John Crispin
2016-01-25 12:30 ` Javier Martinez Canillas
2016-01-25 12:30 ` Javier Martinez Canillas
[not found] ` <CABxcv=kC3tOrfJvCCaXcMSO4ufBXc_GoWeGBcX56k1RV-BX=ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-25 12:33 ` John Crispin
2016-01-25 12:35 ` Mark Brown
2016-01-25 12:35 ` Mark Brown
2016-01-25 13:13 ` John Crispin
2016-01-25 13:13 ` John Crispin
2016-01-25 13:19 ` Javier Martinez Canillas
2016-01-25 13:19 ` Javier Martinez Canillas
2016-01-25 13:25 ` Javier Martinez Canillas
2016-01-25 13:25 ` Javier Martinez Canillas
2016-01-25 13:46 ` John Crispin
2016-01-25 13:46 ` John Crispin
2016-01-25 14:01 ` Javier Martinez Canillas
2016-01-25 14:01 ` Javier Martinez Canillas
2016-01-25 14:02 ` John Crispin [this message]
2016-01-25 14:02 ` John Crispin
[not found] ` <1453718405-40815-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-01-25 11:37 ` [PATCH V2 1/2] dt-bindings: regulator: Add document " Mark Brown
2016-01-25 11:37 ` Mark Brown
2016-01-25 11:37 ` Mark Brown
[not found] ` <20160125113710.GJ6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-25 12:05 ` John Crispin
2016-01-25 12:05 ` John Crispin
2016-01-25 12:05 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A62B0F.2090707@openwrt.org \
--to=blogic@openwrt.org \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=javier@dowhile0.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=steven.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.