From: Eric Auger <eric.auger@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: eric.auger@st.com, "QEMU Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
"Patch Tracking" <patches@linaro.org>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Baptiste Reynal" <b.reynal@virtualopensystems.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
thomas.lendacky@amd.com
Subject: Re: [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for clock node generation
Date: Mon, 25 Jan 2016 15:51:56 +0100 [thread overview]
Message-ID: <56A6368C.5000409@linaro.org> (raw)
In-Reply-To: <CAFEAcA-ByZWz0mpbVJTTsSzyn24M_DnREptu73w=UUtiHK69Hg@mail.gmail.com>
On 01/25/2016 03:43 PM, Peter Maydell wrote:
> On 25 January 2016 at 14:34, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 25 January 2016 at 14:09, Eric Auger <eric.auger@linaro.org> wrote:
>>> Hi Peter,
>>> On 01/25/2016 03:05 PM, Peter Maydell wrote:
>>>> On 18 January 2016 at 15:16, Eric Auger <eric.auger@linaro.org> wrote:
>>
>>>> Don't we want to return here, rather than continuing with the
>>>> rest of the function? ("goto err;" with an err: label before
>>>> the g_free() at the bottom of the function probably best since
>>>> some of the error paths need to free that.)
>>> due to the &error_fatal, we are going to exit here. I thought it is not
>>> worth going further if we can't find the clock node.
>>
>> Yes, sorry, I didn't notice the error_fatal til I got to about
>> the last patch I reviewed. You can ignore similar comments
>> I made about some of the other patches.
>
> ...so if you fix the 'asserts' comment thing, you can have
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
OK thanks for the whole review
Eric
>
> thanks
> -- PMM
>
WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Baptiste Reynal" <b.reynal@virtualopensystems.com>,
"Thomas Huth" <thuth@redhat.com>,
eric.auger@st.com, "Patch Tracking" <patches@linaro.org>,
"Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
thomas.lendacky@amd.com, "Alex Bennée" <alex.bennee@linaro.org>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for clock node generation
Date: Mon, 25 Jan 2016 15:51:56 +0100 [thread overview]
Message-ID: <56A6368C.5000409@linaro.org> (raw)
In-Reply-To: <CAFEAcA-ByZWz0mpbVJTTsSzyn24M_DnREptu73w=UUtiHK69Hg@mail.gmail.com>
On 01/25/2016 03:43 PM, Peter Maydell wrote:
> On 25 January 2016 at 14:34, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 25 January 2016 at 14:09, Eric Auger <eric.auger@linaro.org> wrote:
>>> Hi Peter,
>>> On 01/25/2016 03:05 PM, Peter Maydell wrote:
>>>> On 18 January 2016 at 15:16, Eric Auger <eric.auger@linaro.org> wrote:
>>
>>>> Don't we want to return here, rather than continuing with the
>>>> rest of the function? ("goto err;" with an err: label before
>>>> the g_free() at the bottom of the function probably best since
>>>> some of the error paths need to free that.)
>>> due to the &error_fatal, we are going to exit here. I thought it is not
>>> worth going further if we can't find the clock node.
>>
>> Yes, sorry, I didn't notice the error_fatal til I got to about
>> the last patch I reviewed. You can ignore similar comments
>> I made about some of the other patches.
>
> ...so if you fix the 'asserts' comment thing, you can have
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
OK thanks for the whole review
Eric
>
> thanks
> -- PMM
>
next prev parent reply other threads:[~2016-01-25 14:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 15:16 [PATCH v5 0/8] AMD XGBE KVM platform passthrough Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 1/8] hw/vfio/platform: amd-xgbe device Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 2/8] device_tree: introduce load_device_tree_from_sysfs Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-25 14:13 ` Peter Maydell
2016-01-25 14:13 ` [Qemu-devel] " Peter Maydell
2016-02-01 13:11 ` Eric Auger
2016-02-01 13:11 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 3/8] device_tree: introduce qemu_fdt_node_path Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-25 14:26 ` Peter Maydell
2016-01-25 14:26 ` [Qemu-devel] " Peter Maydell
2016-01-25 14:41 ` Eric Auger
2016-01-25 14:41 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 4/8] device_tree: qemu_fdt_getprop converted to use the error API Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 5/8] device_tree: qemu_fdt_getprop_cell " Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 6/8] hw/arm/sysbus-fdt: helpers for clock node generation Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-25 14:05 ` Peter Maydell
2016-01-25 14:05 ` [Qemu-devel] " Peter Maydell
2016-01-25 14:09 ` Eric Auger
2016-01-25 14:09 ` [Qemu-devel] " Eric Auger
2016-01-25 14:34 ` Peter Maydell
2016-01-25 14:34 ` [Qemu-devel] " Peter Maydell
2016-01-25 14:43 ` Peter Maydell
2016-01-25 14:43 ` [Qemu-devel] " Peter Maydell
2016-01-25 14:51 ` Eric Auger [this message]
2016-01-25 14:51 ` Eric Auger
2016-01-18 15:16 ` [PATCH v5 7/8] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
2016-01-25 14:33 ` Peter Maydell
2016-01-25 14:33 ` [Qemu-devel] " Peter Maydell
2016-02-01 13:11 ` Eric Auger
2016-02-01 13:11 ` [Qemu-devel] " Eric Auger
2016-01-18 15:16 ` [PATCH v5 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check Eric Auger
2016-01-18 15:16 ` [Qemu-devel] " Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6368C.5000409@linaro.org \
--to=eric.auger@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=christoffer.dall@linaro.org \
--cc=crosthwaitepeter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eric.auger@st.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.