Re: [Qemu-devel] [PATCH v5 10/12] fdc: rework pick_geometry

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

On 01/22/2016 01:59 PM, John Snow wrote:
> 
> 
> On 01/22/2016 03:51 PM, John Snow wrote:
>> This one is the crazy one.
>>
>> fd_revalidate currently uses pick_geometry to tell if the diskette
>> geometry has changed upon an eject/insert event, but it won't allow us
>> to insert a 1.44MB diskette into a 2.88MB drive. This is inflexible.
>>
>> The new algorithm applies a new heuristic to guessing disk geometries
>> that allows us to switch diskette types as long as the physical size
>> matches before falling back to the old heuristic.
>>
>> The old one is roughly:
>>  - If the size (sectors) and type matches, choose it.
>>  - Fall back to the first geometry that matched our type.
>>
>> The new one is:
>>  - If the size (sectors) and type matches, choose it.
>>  - If the size (sectors) and physical size match, choose it.
>>  - If the size (sectors) matches at all, choose it begrudgingly.
>>  - Fall back to the first geometry that matched our type.
>>
> 
> Goofed and didn't update commit. Will change on PULL to omit the third
> line if the patch is otherwise OK.

Yep, that's the only thing I noticed.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]