All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Huang Rui <ray.huang@amd.com>, Gioh Kim <gi-oh.kim@profitbricks.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [lm-sensors] [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit
Date: Tue, 26 Jan 2016 02:43:59 +0000	[thread overview]
Message-ID: <56A6DD6F.9080704@roeck-us.net> (raw)
In-Reply-To: <20160126022531.GA23394@hr-amur2>

On 01/25/2016 06:25 PM, Huang Rui wrote:
> On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote:
>> The bits [31:29] of D18F5xE8 TDP Limit3 are reserved.
>> I think it'd better to add masking to read ApmTdpLimit[28:16] precisely.
>>
>> Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
>> ---
>>   drivers/hwmon/fam15h_power.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c
>> index f77eb97..f9647c8 100644
>> --- a/drivers/hwmon/fam15h_power.c
>> +++ b/drivers/hwmon/fam15h_power.c
>> @@ -90,7 +90,7 @@ static ssize_t show_power(struct device *dev,
>>   	pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),
>>   				  REG_TDP_LIMIT3, &val);
>>
>> -	tdp_limit = val >> 16;
>> +	tdp_limit = (val >> 16) & 0x1fff;
>
>
> Thanks to send the patch on fam15h_power driver. :-)
> In latest AMD (family 15h, Model 60h) processor, ApmTdpLimit field is
> expanded to [32:16]. The orignal reserved bits actually are reserved
> for ApmTdpLimit expansion.
>
> http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf
>
> Guenter, Will I collect all patches of fam15h_power and send them to
> you, or ack it that you can apply directly?
>

Ack is fine. No need to make things more complicated than necessary.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Huang Rui <ray.huang@amd.com>, Gioh Kim <gi-oh.kim@profitbricks.com>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit
Date: Mon, 25 Jan 2016 18:43:59 -0800	[thread overview]
Message-ID: <56A6DD6F.9080704@roeck-us.net> (raw)
In-Reply-To: <20160126022531.GA23394@hr-amur2>

On 01/25/2016 06:25 PM, Huang Rui wrote:
> On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote:
>> The bits [31:29] of D18F5xE8 TDP Limit3 are reserved.
>> I think it'd better to add masking to read ApmTdpLimit[28:16] precisely.
>>
>> Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
>> ---
>>   drivers/hwmon/fam15h_power.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c
>> index f77eb97..f9647c8 100644
>> --- a/drivers/hwmon/fam15h_power.c
>> +++ b/drivers/hwmon/fam15h_power.c
>> @@ -90,7 +90,7 @@ static ssize_t show_power(struct device *dev,
>>   	pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5),
>>   				  REG_TDP_LIMIT3, &val);
>>
>> -	tdp_limit = val >> 16;
>> +	tdp_limit = (val >> 16) & 0x1fff;
>
>
> Thanks to send the patch on fam15h_power driver. :-)
> In latest AMD (family 15h, Model 60h) processor, ApmTdpLimit field is
> expanded to [32:16]. The orignal reserved bits actually are reserved
> for ApmTdpLimit expansion.
>
> http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf
>
> Guenter, Will I collect all patches of fam15h_power and send them to
> you, or ack it that you can apply directly?
>

Ack is fine. No need to make things more complicated than necessary.

Thanks,
Guenter

  reply	other threads:[~2016-01-26  2:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 11:41 [lm-sensors] [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit Gioh Kim
2016-01-25 11:41 ` Gioh Kim
2016-01-26  2:25 ` [lm-sensors] " Huang Rui
2016-01-26  2:25   ` Huang Rui
2016-01-26  2:43   ` Guenter Roeck [this message]
2016-01-26  2:43     ` Guenter Roeck
2016-01-26 10:57   ` [lm-sensors] " Gi-Oh Kim
2016-01-26 10:57     ` Gi-Oh Kim
2016-01-27  6:45     ` [lm-sensors] " Huang Rui
2016-01-27  6:45       ` Huang Rui
2016-01-27 10:36       ` [lm-sensors] " Gi-Oh Kim
2016-01-27 10:36         ` Gi-Oh Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A6DD6F.9080704@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=bp@alien8.de \
    --cc=gi-oh.kim@profitbricks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.