All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Crispin <blogic@openwrt.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Chen Zhong <chen.zhong@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Henry Chen <henryc.chen@mediatek.com>,
	Steven Liu <steven.liu@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Tue, 26 Jan 2016 11:59:59 +0100	[thread overview]
Message-ID: <56A751AF.3030601@openwrt.org> (raw)
In-Reply-To: <1453804890.17181.93.camel@tiscali.nl>



On 26/01/2016 11:41, Paul Bolle wrote:
> John,
> 
> On ma, 2016-01-25 at 12:56 +0100, John Crispin wrote:
>> --- /dev/null
>> +++ b/drivers/regulator/mt6323-regulator.c
> 
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
> 
> This states this file is licensed GPL v2 only.
> 
>> +MODULE_LICENSE("GPL");
> 
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
> 
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
> 
> Thanks,
> 
> 
> Paul Bolle
> 

Hi Paul,

thanks, good catch. luckily i had not sent the next version of the
series yet ;)

	John

	John

WARNING: multiple messages have this Message-ID (diff)
From: blogic@openwrt.org (John Crispin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Tue, 26 Jan 2016 11:59:59 +0100	[thread overview]
Message-ID: <56A751AF.3030601@openwrt.org> (raw)
In-Reply-To: <1453804890.17181.93.camel@tiscali.nl>



On 26/01/2016 11:41, Paul Bolle wrote:
> John,
> 
> On ma, 2016-01-25 at 12:56 +0100, John Crispin wrote:
>> --- /dev/null
>> +++ b/drivers/regulator/mt6323-regulator.c
> 
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
> 
> This states this file is licensed GPL v2 only.
> 
>> +MODULE_LICENSE("GPL");
> 
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
> 
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
> 
> Thanks,
> 
> 
> Paul Bolle
> 

Hi Paul,

thanks, good catch. luckily i had not sent the next version of the
series yet ;)

	John

	John

  reply	other threads:[~2016-01-26 10:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 11:56 [PATCH V3 1/2] regulator: Add document for MT6323 regulator John Crispin
2016-01-25 11:56 ` John Crispin
2016-01-25 11:56 ` [PATCH V3 2/2] regulator: mt6323: Add support " John Crispin
2016-01-25 11:56   ` John Crispin
2016-01-25 12:48   ` kbuild test robot
2016-01-25 12:48     ` kbuild test robot
2016-01-25 12:48     ` kbuild test robot
     [not found]   ` <1453722989-41622-2-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-01-26 10:41     ` Paul Bolle
2016-01-26 10:41       ` Paul Bolle
2016-01-26 10:41       ` Paul Bolle
2016-01-26 10:59       ` John Crispin [this message]
2016-01-26 10:59         ` John Crispin
     [not found] ` <1453722989-41622-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-01-26  2:31   ` [PATCH V3 1/2] regulator: Add document " Rob Herring
2016-01-26  2:31     ` Rob Herring
2016-01-26  2:31     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A751AF.3030601@openwrt.org \
    --to=blogic@openwrt.org \
    --cc=broonie@kernel.org \
    --cc=chen.zhong@mediatek.com \
    --cc=henryc.chen@mediatek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pebolle@tiscali.nl \
    --cc=steven.liu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.