From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] nbd: add missed aio_context_acquire in nbd_export_new
Date: Tue, 26 Jan 2016 12:37:15 +0100 [thread overview]
Message-ID: <56A75A6B.9050308@redhat.com> (raw)
In-Reply-To: <1453273940-15382-3-git-send-email-den@openvz.org>
On 20/01/2016 08:12, Denis V. Lunev wrote:
> blk_invalidate_cache() can call qcow2_invalidate_cache which performs
> IO inside.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> ---
> nbd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/nbd.c b/nbd.c
> index b3d9654..b271db5 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1080,7 +1080,9 @@ NBDExport *nbd_export_new(BlockBackend *blk, off_t dev_offset, off_t size,
> * that BDRV_O_INCOMING is cleared and the image is ready for write
> * access since the export could be available before migration handover.
> */
> + aio_context_acquire(exp->ctx);
> blk_invalidate_cache(blk, NULL);
> + aio_context_release(exp->ctx);
> return exp;
>
> fail:
>
Queuing this one myself.
Paolo
next prev parent reply other threads:[~2016-01-26 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 7:12 [Qemu-devel] [PATCH 0/2] fixes for bdrv_invalidate_cache Denis V. Lunev
2016-01-20 7:12 ` [Qemu-devel] [PATCH 1/2] block: fix assert in qcow2_get_specific_info Denis V. Lunev
2016-01-29 8:39 ` Denis V. Lunev
2016-02-02 13:20 ` Paolo Bonzini
2016-02-02 13:49 ` Denis V. Lunev
2016-02-02 14:26 ` Paolo Bonzini
2016-01-20 7:12 ` [Qemu-devel] [PATCH 2/2] nbd: add missed aio_context_acquire in nbd_export_new Denis V. Lunev
2016-01-26 11:37 ` Paolo Bonzini [this message]
2016-01-25 11:59 ` [Qemu-devel] [PATCH 0/2] fixes for bdrv_invalidate_cache Denis V. Lunev
2016-02-02 9:50 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A75A6B.9050308@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.